From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite Date: Mon, 29 Oct 2012 09:32:41 -0700 Message-ID: <20121029093241.4b168cc0@jbarnes-desktop> References: <1351272650-8402-1-git-send-email-damien.lespiau@gmail.com> <20121026104254.6d4896ef@jbarnes-desktop> <6c3329$6ur22h@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 2E0789E8D1 for ; Mon, 29 Oct 2012 09:32:36 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Lespiau, Damien" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 29 Oct 2012 15:20:15 +0000 "Lespiau, Damien" wrote: > On Sun, Oct 28, 2012 at 10:04 AM, Chris Wilson wrote: > > We do. However, we don't catch userspace changing the tiling on an > > existing fb (unless actually pinned)... The extra level of defense is > > certainly welcome, and provides documentation at all levels on the known > > capabilities of the hw. (The only downside is that we have more guards to > > fixup if those ever change, but unlikely ;) > > I've sent a new version of this one then, turns out it be useful to > catch cases where one changes the tiling mode after the creation of > the fb. > Ok sounds good. I'll add my r-b to the latest one. -- Jesse Barnes, Intel Open Source Technology Center