From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object
Date: Mon, 29 Oct 2012 11:33:57 -0200 [thread overview]
Message-ID: <20121029133356.GC6754@infradead.org> (raw)
In-Reply-To: <20121029111328.GA1123@krava.redhat.com>
Em Mon, Oct 29, 2012 at 12:13:28PM +0100, Jiri Olsa escreveu:
> On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote:
> > On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote:
> > > separating dso related stuff into dso object plus some other symbol
> > > object cleanup. It's just a code moving, no actual change was done.
> > Looks good to me.
> > Arnaldo, if you want, you can add my Reviewed- or Tested-by tags for this
> > series.
> humm, so you could compile it wth no problem..? what system are you? ;)
util/dso.c:1:20: error: symbol.h: No such file or directory
[acme@sandy linux]$ head -4 tools/perf/util/dso.c
#include <symbol.h>
#include "dso.h"
#include "util.h"
#include "debug.h"
[acme@sandy linux]$
If I use "symbol.h" it builds, I've fixed this one here, thanks.
The problem is that I use O=, building it without it works.
- ARnaldo
prev parent reply other threads:[~2012-10-29 13:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 21:18 [PATCH 0/5] perf dso: Separate dso symbols to separate object Jiri Olsa
2012-10-27 21:18 ` [PATCH 1/5] perf tool: Move build_id__sprintf into build-id object Jiri Olsa
2012-10-30 11:59 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 2/5] perf tool: Move BUILD_ID_SIZE " Jiri Olsa
2012-10-30 12:00 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 3/5] perf tool: Move hex2u64 into util object Jiri Olsa
2012-10-30 12:01 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 4/5] perf tool: Move strxfrchar into string object Jiri Olsa
2012-10-30 12:02 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 5/5] perf tool: Move dso_* related functions into dso object Jiri Olsa
2012-10-28 13:37 ` Arnaldo Carvalho de Melo
2012-10-28 18:42 ` Jiri Olsa
2012-10-28 21:16 ` Arnaldo Carvalho de Melo
2012-10-30 12:04 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-29 11:07 ` [PATCH 0/5] perf dso: Separate dso symbols to separate object Namhyung Kim
2012-10-29 11:13 ` Jiri Olsa
2012-10-29 11:20 ` Namhyung Kim
2012-10-29 13:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029133356.GC6754@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.