From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr
Date: Mon, 29 Oct 2012 14:54:55 +0100 [thread overview]
Message-ID: <20121029135455.GA28797@ohm.aurel32.net> (raw)
In-Reply-To: <1351486220-26216-1-git-send-email-rth@twiddle.net>
On Mon, Oct 29, 2012 at 03:50:20PM +1100, Richard Henderson wrote:
> There is some read-after-write error within the OP=2 insns which
> prevents setting cpu_dst to the real output register. Until this
> is found and fixed, always write to a temporary first.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 4321393..9e46f14 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -2633,7 +2633,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
> case 2: /* FPU & Logical Operations */
> {
> unsigned int xop = GET_FIELD(insn, 7, 12);
> - TCGv cpu_dst = gen_dest_gpr(dc, rd);
> + TCGv cpu_dst = get_temp_tl(dc);
> TCGv cpu_tmp0;
>
> if (xop == 0x3a) { /* generate trap */
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-10-29 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 4:50 [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr Richard Henderson
2012-10-29 13:54 ` Aurelien Jarno [this message]
2012-10-30 21:08 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029135455.GA28797@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.