All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE
Date: Mon, 29 Oct 2012 15:34:22 +0100	[thread overview]
Message-ID: <20121029143422.GA8410@ohm.aurel32.net> (raw)
In-Reply-To: <5085B858.9070205@twiddle.net>

On Tue, Oct 23, 2012 at 07:19:20AM +1000, Richard Henderson wrote:
> On 2012-10-22 15:59, Aurelien Jarno wrote:
> > Yes, this is a know fact that this libc function doesn't have a
> > prototype (for instance in the manpage), that said it exists and at
> > least on x32 it's actually a wrapper doing things.
> > 
> > That's why I think it's better to use it than doing the syscall
> > directly.
> 
> Well, we know that arch_prctl is not a wrapper for x86_64.  And x32
> will never be a concern for qemu.  But I guess I can change this if
> you really really insist.
> 

My point here is that arch_prctl might be a wrapper for x86_64 at some
point, so it's better to do it properly now, and not to have to change
it latter.

In order to avoid one more round trip for a new version of the patch, I
have applied it doing this small changes.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

  reply	other threads:[~2012-10-29 14:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22  2:11 [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE Richard Henderson
2012-10-22  5:59 ` Aurelien Jarno
2012-10-22 21:19   ` Richard Henderson
2012-10-29 14:34     ` Aurelien Jarno [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-18  3:28 [Qemu-devel] [PATCH] " Richard Henderson
2012-10-18  3:36 ` [Qemu-devel] [PATCH v2] " Richard Henderson
2012-10-21  4:26   ` Aurelien Jarno
2012-10-21  6:24     ` Richard Henderson
2012-10-21 20:43     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121029143422.GA8410@ohm.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.