From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/4] ASoC: ak5702: add support for ak5702 -- 4ch ADC Date: Mon, 29 Oct 2012 16:04:51 +0000 Message-ID: <20121029160450.GB4511@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7037568730471536546==" Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id C4190265D26 for ; Mon, 29 Oct 2012 17:04:52 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Paolo Doz Cc: alsa-devel@alsa-project.org, lrg@ti.com List-Id: alsa-devel@alsa-project.org --===============7037568730471536546== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5" Content-Disposition: inline --CUfgB8w4ZwR/yMy5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 29, 2012 at 09:43:57AM +0100, Paolo Doz wrote: > This codec driver adds support for Asahi Kasei AK5702. >=20 > Signed-off-by: Paolo Doz Lars-Peter already went through most of this so I'll not follow up in detail. One overall comment which Lars-Peter didn't make but which it's worth bearing in mind was that your driver looks like it was written several years ago, it'd probably help a lot if you were to look at more modern drivers and make sure what you're doing resembles them stylistically. --CUfgB8w4ZwR/yMy5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQjqkcAAoJELSic+t+oim9SssP+wd/uNMF8ODKv64XKsXQI5Jt /SU0VSuLA8cTDqIIhVHT0PZFMQ0p1n1+6zDCZu/7kF0fCTwhcXOTi7la1yJanfN6 WrWqfDwelNpaT45S5VZZYamEKh+TnQ+04f0dcg8EUfdCHFuZobR98kwSNT5tJxYp LwblC3/LWtYWiaIjZdNaAdaPkXjpHJZro5Ho1/IFLX0r2wlJ2zqb3TXljRfdpaO1 TUY1SP+IfIGoFPHOdZx5ZzgG7EP+dlUrV2fySSyTTqsHlRAUTbBddcDIaoI9KqTj bcBgCqwcsvgq07LwT+N0u4Jvn9sLH4KZsK8MtT6dSXgXZhKGr8UK5FfHc0MQnUxb 97o6a2XcQBKMLs3s7eZOrOqcq2J1TplWXc4khKYVDfQPUwL858LFbzJwWaU07r4+ USHPV7BaIUy85uUuR3cmx7R22XxKp/BPJIRqrVaVfPSDt3yydzpmq1TLQHCVFWkz G9yfwVDpnfGZQjAOGtApXRgeY9+mpC82g7fGO70D39bcZazSQEXv5miDyNmpbH43 2Yp6/HG1t6u6Wefr97JAw53iRjoxb9jJTomikc7nUuyyuvX6N/oRgdP4GaMRz7hy mhRQhyYio79KXA+PpDoKV2hKdKuhxqCjWS+LjGsKmoE0SowySIesyaJJuqRXpP3O kNTCj425jbeG47tQBodo =x2ND -----END PGP SIGNATURE----- --CUfgB8w4ZwR/yMy5-- --===============7037568730471536546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7037568730471536546==--