From: Andrew Morton <akpm@linux-foundation.org>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: hirofumi@mail.parknet.co.jp, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ravishankar N <ravi.n1@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode
Date: Mon, 29 Oct 2012 16:49:36 -0700 [thread overview]
Message-ID: <20121029164936.2022db6c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1351389223-2628-1-git-send-email-linkinjeon@gmail.com>
On Sun, 28 Oct 2012 10:53:43 +0900
Namjae Jeon <linkinjeon@gmail.com> wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> fat_nfs_get_inode does not hold i_mutex of parent directory.So add
> lock to fat_build_inode.
Well.. why? Presumably this patch fixes some race. A good
description of that race would be useful - partly because others may
then be able to suggest alternative ways of fixing that bug.
I'll merge these patches for some testing.
I did merge these patches three weekes ago:
fat-modify-nfs-mount-option.patch
fat-exportfs-rebuild-inode-if-ilookup-fails.patch
fat-exportfs-rebuild-inode-if-ilookup-fails-fix.patch
fat-exportfs-rebuild-directory-inode-if-fat_dget-fails.patch
documentation-update-nfs-option-in-filesystem-vfattxt.patch
But I have no record of Bruce or Ogawa having reviewed/acked them?
next prev parent reply other threads:[~2012-10-29 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 1:53 [PATCH 5/5] fat: add mutex lock to fat_build_inode Namjae Jeon
2012-10-29 23:49 ` Andrew Morton [this message]
2012-10-30 4:24 ` Namjae Jeon
2012-10-31 0:46 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029164936.2022db6c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.sahrawat@samsung.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=ravi.n1@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.