From: William Dauchy <william@gandi.net>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Pekka Enberg <penberg@kernel.org>,
Asias He <asias.hejun@gmail.com>, Ingo Molnar <mingo@elte.hu>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm tools: fix rbtree-interval search
Date: Mon, 29 Oct 2012 17:51:41 +0100 [thread overview]
Message-ID: <20121029165141.GG1109@gandi.net> (raw)
In-Reply-To: <1351512780-8563-1-git-send-email-kirill.shutemov@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Oct29 14:12, Kirill A. Shutemov wrote:
> I've noticed message on kvm exit:
>
> Warning: serial8250__exit failed.
>
> kvm tool is not able to remove ioport range which was added previously.
>
> The issue is caused by bug in rbtree-interval. Search algorithm in
> rb_int_search_single() expects correct value of max_high. But the tree
> can contain leaf nodes, which never were updated by propagate_callback().
> For this kind of nodes high_max will be 0 and we will not be able to
> find and remove them.
>
> Let's initialize max_high on RB_INT_INIT() time.
>
> Fixing this bug makes other bug visible: propagate_callback() can be
> called for empty tree: node == NULL. The callback is not ready for empty
> tree. Let's fix that as well.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
I had the same issue but didn't found the time to fix it.
Applying the patch fixes the problem.
Tested-by: William Dauchy <william@gandi.net>
Thanks,
--
William
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-10-29 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 12:12 [PATCH] kvm tools: fix rbtree-interval search Kirill A. Shutemov
2012-10-29 16:51 ` William Dauchy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029165141.GG1109@gandi.net \
--to=william@gandi.net \
--cc=asias.hejun@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.