From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, jolsa@redhat.com,
ming.m.lin@intel.com
Subject: Re: [Patch v1 04/10] perf/x86: add memory profiling via PEBS Load Latency
Date: Mon, 29 Oct 2012 12:42:03 -0700 [thread overview]
Message-ID: <20121029194203.GK2266@tassilo.jf.intel.com> (raw)
In-Reply-To: <1351523752-4215-5-git-send-email-eranian@google.com>
> +
> +struct attribute *nhm_events_attrs[] = {
> + EVENT_PTR(CPU_CYCLES),
> + EVENT_PTR(INSTRUCTIONS),
> + EVENT_PTR(CACHE_REFERENCES),
> + EVENT_PTR(CACHE_MISSES),
> + EVENT_PTR(BRANCH_INSTRUCTIONS),
> + EVENT_PTR(BRANCH_MISSES),
> + EVENT_PTR(BUS_CYCLES),
> + EVENT_PTR(STALLED_CYCLES_FRONTEND),
> + EVENT_PTR(STALLED_CYCLES_BACKEND),
> + EVENT_PTR(REF_CPU_CYCLES),
> + EVENT_PTR(mem_ld_nhm),
> + NULL,
> +};
I thought Jiri's patch already exports all the generic ones?
Why do you need to replace the whole table?
BTW I still think my approach in the v4 Haswell patchkit
is simpler and didn't rely on hardcoding these events.
-Andi
next prev parent reply other threads:[~2012-10-29 19:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 15:15 [Patch v1 00/10] perf: add memory access sampling support Stephane Eranian
2012-10-29 15:15 ` [Patch v1 01/10] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2012-10-29 19:25 ` Andi Kleen
2012-10-29 15:15 ` [Patch v1 02/10] perf/x86: add flags to event constraints Stephane Eranian
2012-10-29 15:15 ` [Patch v1 03/10] perf: add generic memory sampling interface Stephane Eranian
2012-10-29 15:15 ` [Patch v1 04/10] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2012-10-29 15:23 ` Peter Zijlstra
2012-10-29 15:24 ` Stephane Eranian
2012-10-29 15:35 ` Peter Zijlstra
2012-10-29 15:39 ` Stephane Eranian
2012-10-29 15:38 ` Peter Zijlstra
2012-10-29 15:43 ` Stephane Eranian
2012-10-29 15:44 ` Peter Zijlstra
2012-10-29 19:42 ` Andi Kleen [this message]
2012-10-29 20:39 ` Stephane Eranian
2012-10-29 20:44 ` Peter Zijlstra
2012-10-29 21:16 ` Andi Kleen
2012-10-29 21:32 ` Stephane Eranian
2012-10-29 21:56 ` Andi Kleen
2012-10-30 8:43 ` Namhyung Kim
2012-10-29 15:15 ` [Patch v1 05/10] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-10-29 15:15 ` [Patch v1 06/10] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-10-29 15:40 ` Peter Zijlstra
2012-10-29 15:44 ` Stephane Eranian
2012-10-31 5:21 ` Namhyung Kim
2012-10-31 13:28 ` Stephane Eranian
2012-10-29 15:15 ` [Patch v1 07/10] perf tools: add mem access sampling core support Stephane Eranian
2012-10-29 16:55 ` Andi Kleen
2012-10-29 17:00 ` Stephane Eranian
2012-10-31 5:51 ` Namhyung Kim
2012-10-31 13:30 ` Stephane Eranian
2012-10-29 15:15 ` [Patch v1 08/10] perf report: add support for mem access profiling Stephane Eranian
2012-10-31 6:01 ` Namhyung Kim
2012-10-29 15:15 ` [Patch v1 09/10] perf record: " Stephane Eranian
2012-10-29 15:15 ` [Patch v1 10/10] perf tools: add new mem command for memory " Stephane Eranian
2012-10-31 6:57 ` Namhyung Kim
2012-10-31 14:23 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029194203.GK2266@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.