From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760702Ab2J2UPX (ORCPT ); Mon, 29 Oct 2012 16:15:23 -0400 Received: from mail.kernel.org ([198.145.19.201]:42691 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760659Ab2J2UJC (ORCPT ); Mon, 29 Oct 2012 16:09:02 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , alan@lxorguk.ukuu.org.uk, Len Sorensen , Johan Hovold Subject: [ 18/34] USB: serial: Fix memory leak in sierra_release() Date: Mon, 29 Oct 2012 13:07:49 -0700 Message-Id: <20121029200422.593103939@linuxfoundation.org> X-Mailer: git-send-email 1.7.12.2.421.g261b511 In-Reply-To: <20121029200420.550338074@linuxfoundation.org> References: <20121029200420.550338074@linuxfoundation.org> User-Agent: quilt/0.60-2.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lennart Sorensen commit f7bc5051667b74c3861f79eed98c60d5c3b883f7 upstream. I found a memory leak in sierra_release() (well sierra_probe() I guess) that looses 8 bytes each time the driver releases a device. Signed-off-by: Len Sorensen Acked-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/sierra.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c @@ -993,6 +993,7 @@ static void sierra_release(struct usb_se continue; kfree(portdata); } + kfree(serial->private); } #ifdef CONFIG_PM