From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
Date: Mon, 29 Oct 2012 21:55:03 +0100 [thread overview]
Message-ID: <20121029205503.GX24458@pengutronix.de> (raw)
In-Reply-To: <1351415710-19380-2-git-send-email-plagnioj@jcrosoft.com>
On Sun, Oct 28, 2012 at 10:15:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/console.c | 3 +++
> 1 file changed, 3 insertions(+)
Dropped this one as it breaks most defconfigs with:
common/console.c: In function 'console_std_set':
common/console.c:90:3: warning: implicit declaration of function 'PUTS_LL' [-Wimplicit-function-declaration]
common/built-in.o: In function `console_std_set':
bootargs.c:(.text.console_std_set+0xf8): undefined reference to `PUTS_LL'
bootargs.c:(.text.console_std_set+0x104): undefined reference to `PUTS_LL'
bootargs.c:(.text.console_std_set+0x10c): undefined reference to `PUTS_LL'
Sascha
>
> diff --git a/common/console.c b/common/console.c
> index 2e8c973..fdd5f42 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -88,6 +88,9 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
> if (initialized < CONSOLE_INIT_FULL) {
> char ch;
> initialized = CONSOLE_INIT_FULL;
> + PUTS_LL("Switch to console [");
> + PUTS_LL(dev_name(dev));
> + PUTS_LL("]\n");
> barebox_banner();
> while (kfifo_getc(console_output_fifo, &ch) == 0)
> console_putc(CONSOLE_STDOUT, ch);
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-29 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 9:15 [PATCH 1/2] debug_ll: use const char* for PUTS_LL Jean-Christophe PLAGNIOL-VILLARD
2012-10-28 9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
2012-10-29 20:55 ` Sascha Hauer [this message]
2012-10-30 8:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-30 9:26 ` Sascha Hauer
2012-10-29 7:39 ` [PATCH 1/2] debug_ll: use const char* for PUTS_LL Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029205503.GX24458@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.