From: Greg KH <gregkh@linuxfoundation.org>
To: Anmol Sarma <unmole.in@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: binder: Fixed multi-line strings
Date: Mon, 29 Oct 2012 14:53:36 -0700 [thread overview]
Message-ID: <20121029215336.GA13740@kroah.com> (raw)
In-Reply-To: <1351239859-6585-1-git-send-email-unmole.in@gmail.com>
On Fri, Oct 26, 2012 at 01:54:19PM +0530, Anmol Sarma wrote:
> if (vma == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed to "
> - "map pages in userspace, no vma\n", proc->pid);
> + pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> + proc->pid);
> goto err_no_vma;
> }
>
> @@ -585,8 +587,8 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
> BUG_ON(*page);
> *page = alloc_page(GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO);
> if (*page == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed "
> - "for page at %p\n", proc->pid, page_addr);
> + pr_err("%d: binder_alloc_buf failed for page at %p\n",
> + proc->pid, page_addr);
> goto err_alloc_page_failed;
> }
> tmp_area.addr = page_addr;
What's with the very wierd indentation here for the second line? Please
indent it properly, one space isn't ok.
greg k-h
next prev parent reply other threads:[~2012-10-29 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 19:01 [PATCH] Staging: android: binder: Fixed multi-line strings Anmol Sarma
2012-10-08 23:15 ` Joe Perches
2012-10-22 20:02 ` Greg KH
2012-10-23 9:43 ` Anmol Sarma
2012-10-24 4:13 ` Greg KH
2012-10-24 7:58 ` Anmol Sarma
2012-10-24 22:29 ` Greg KH
2012-10-25 8:06 ` Anmol Sarma
2012-10-25 19:25 ` Greg KH
2012-10-26 7:26 ` Anmol Sarma
2012-10-26 8:24 ` Anmol Sarma
2012-10-29 21:53 ` Greg KH [this message]
2012-10-30 17:05 ` Anmol Sarma
2012-10-09 8:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029215336.GA13740@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=unmole.in@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.