From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement
Date: Tue, 30 Oct 2012 09:37:22 -0400 [thread overview]
Message-ID: <20121030133720.GA27463@phenom.dumpdata.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC8292335374C86@SHSMSX101.ccr.corp.intel.com>
> > +config XEN_ACPI_PAD_STUB
> > + bool
> > + depends on XEN_DOM0 && X86_64 && ACPI
> > + default n
> > +
>
> This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native pad would successfully registerred, and then mwait #UD (we would revert df88b2d96e36d9a9e325bfcd12eb45671cbbc937, right?). So xen stub logic should unconditionally built-in kernel.
Potentially. Keep in mind that there is no need to built this if the
kernel is not built with ACPI.
.. snip.
> > +subsys_initcall(xen_acpi_pad_stub_init);
>
> I'm still confused. In this way there are xen-acpi-pad-stub.c and xen-acpi-pad.c, and you want to let xen-acpi-pad loaded as module, right? how can xen-acpi-pad logic work when it was insmoded?
Via the register/unregister calls that this provides? Or does ACPI bus
drivers get immediately called once the call acpi_bus_register_driver?
Or can one 'poke' the 'add' and 'remove' calls so that once the "true"
PAD driver is loaded it will restart the ops->add call?
next prev parent reply other threads:[~2012-10-30 13:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 12:19 [PATCH 1/2] Xen acpi pad implement Liu, Jinsong
2012-10-25 14:23 ` [Xen-devel] " Jan Beulich
2012-10-26 6:18 ` Liu, Jinsong
2012-10-26 12:02 ` Jan Beulich
2012-10-26 12:37 ` Liu, Jinsong
2012-10-26 14:00 ` Liu, Jinsong
2012-10-26 20:14 ` Konrad Rzeszutek Wilk
2012-10-29 3:38 ` Liu, Jinsong
2012-10-29 12:39 ` Konrad Rzeszutek Wilk
2012-10-30 7:58 ` Liu, Jinsong
2012-10-30 13:37 ` Konrad Rzeszutek Wilk [this message]
2012-10-30 15:18 ` Liu, Jinsong
2012-10-31 13:51 ` Konrad Rzeszutek Wilk
2012-10-31 15:07 ` Liu, Jinsong
2012-11-01 6:34 ` Liu, Jinsong
2012-11-02 16:49 ` Konrad Rzeszutek Wilk
2012-11-03 12:16 ` Liu, Jinsong
2012-11-05 8:29 ` Jan Beulich
2012-11-05 15:16 ` Stefano Stabellini
2012-11-06 5:48 ` Liu, Jinsong
2012-11-06 6:15 ` Liu, Jinsong
2012-11-06 14:56 ` Stefano Stabellini
2012-11-06 16:23 ` Liu, Jinsong
2012-11-06 16:43 ` Konrad Rzeszutek Wilk
2012-11-07 12:58 ` Liu, Jinsong
2012-11-07 16:03 ` Konrad Rzeszutek Wilk
2012-11-07 16:52 ` Liu, Jinsong
2012-11-08 1:08 ` Konrad Rzeszutek Wilk
2012-11-06 18:28 ` Shuah Khan
2012-11-07 13:06 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030133720.GA27463@phenom.dumpdata.com \
--to=konrad@kernel.org \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.