From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, fweisbec@gmail.com
Subject: Re: [PATCH 1/9] perf python: add ui stubs file
Date: Tue, 30 Oct 2012 08:53:38 -0700 [thread overview]
Message-ID: <20121030155338.GA28061@ghostprotocols.net> (raw)
In-Reply-To: <508FE808.2030306@gmail.com>
Em Tue, Oct 30, 2012 at 08:45:28AM -0600, David Ahern escreveu:
> On 10/30/12 1:24 AM, Namhyung Kim wrote:
> >On Mon, 29 Oct 2012 10:31:41 -0600, David Ahern wrote:
> >>stdio based implementations of ui_xxxx based functions for the python
> >>library. Needed for patch 3 - consolidating open counters method.
> >How about adding ui/util.c to the python-ext-sources?
> Handles some of the ui_xxxx functions, but still missing some
> symbols -- verbose, eprintf, ui__error_paranoid. The point of the
> python_stubs.c was a short term solution for the ui handlers.
> Arnaldo had some ideas on what is really needed.
Yes, and that is something like what Namhyung did for perf_target, i.e.
don't call ui__ stuff from the evsel/evlist classes but use a
perf_evlist__strerror, merge perf_evlist__open_counters() with
perf_evlist__open(), use just perf_evlist__open() everywhere, so that
all tools get the fallbacks for features not present in older kernels,
etc.
- Arnaldo
next prev parent reply other threads:[~2012-10-30 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 16:31 [PATCH 0/9 v2] perf: consolidate all the open counters loops David Ahern
2012-10-29 16:31 ` [PATCH 1/9] perf python: add ui stubs file David Ahern
2012-10-30 7:24 ` Namhyung Kim
2012-10-30 14:45 ` David Ahern
2012-10-30 15:53 ` Arnaldo Carvalho de Melo [this message]
2012-10-31 7:18 ` Namhyung Kim
2012-10-29 16:31 ` [PATCH 2/9] perf top: make use of perf_record_opts David Ahern
2012-10-30 7:27 ` Namhyung Kim
2012-10-30 13:31 ` David Ahern
2012-10-29 16:31 ` [PATCH 3/9] perf evlist: introduce open counters method David Ahern
2012-10-29 16:31 ` [PATCH 4/9] perf top: use the new perf_evlist__open_counters method David Ahern
2012-10-29 16:31 ` [PATCH 5/9] perf record: " David Ahern
2012-10-29 16:31 ` [PATCH 6/9] perf stat: move user options to perf_record_opts David Ahern
2012-10-29 16:31 ` [PATCH 7/9] perf evlist: add stat unique code to open_counters method David Ahern
2012-10-29 16:31 ` [PATCH 8/9] perf stat: move to perf_evlist__open_counters David Ahern
2012-10-29 16:31 ` [PATCH 9/9] perf evsel: remove perf_evsel__open_per_cpu David Ahern
-- strict thread matches above, loose matches on Subject: below --
2012-10-11 4:25 [PATCH 0/9] perf: consolidate all the open counters loops David Ahern
2012-10-11 4:25 ` [PATCH 1/9] perf python: add ui stubs file David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030155338.GA28061@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.