All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	Koen Kooi <koen@dominion.thruhere.net>,
	Matt Porter <mporter@ti.com>, Russ Dill <Russ.Dill@ti.com>
Subject: Re: [PATCH] omap2-clk: Add missing lcdc clock definition
Date: Tue, 30 Oct 2012 11:18:38 -0700	[thread overview]
Message-ID: <20121030181837.GM11908@atomide.com> (raw)
In-Reply-To: <1351698962-3923-1-git-send-email-panto@antoniou-consulting.com>

* Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:04]:
> Looks like the lcdc clock definition got dropped.
> It is required for the LCD controller to work. Reintroduce.

This looks like a regression, can you also add the commit
causing it?

Regards,

Tony
 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
>  arch/arm/mach-omap2/clock33xx_data.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
> index 1a45d6b..b7b7995 100644
> --- a/arch/arm/mach-omap2/clock33xx_data.c
> +++ b/arch/arm/mach-omap2/clock33xx_data.c
> @@ -867,6 +867,16 @@ static struct clk lcd_gclk = {
>  	.recalc		= &followparent_recalc,
>  };
>  
> +static struct clk lcdc_fck = {
> +	.name           = "lcdc_fck",
> +	.clkdm_name     = "lcdc_clkdm",
> +	.parent         = &lcd_gclk,
> +	.enable_reg     = AM33XX_CM_PER_LCDC_CLKCTRL,
> +	.enable_bit     = AM33XX_MODULEMODE_SWCTRL,
> +	.ops            = &clkops_omap2_dflt,
> +	.recalc         = &followparent_recalc,
> +};
> +
>  static struct clk mmc_clk = {
>  	.name		= "mmc_clk",
>  	.clkdm_name	= "l4ls_clkdm",
> @@ -1075,6 +1085,7 @@ static struct omap_clk am33xx_clks[] = {
>  	CLK(NULL,	"clkout2_ck",		&clkout2_ck,	CK_AM33XX),
>  	CLK(NULL,	"timer_32k_ck",		&clkdiv32k_ick,	CK_AM33XX),
>  	CLK(NULL,	"timer_sys_ck",		&sys_clkin_ck,	CK_AM33XX),
> +	CLK("da8xx_lcdc.0",     NULL,           &lcdc_fck,      CK_AM33XX),
>  };
>  
>  int __init am33xx_clk_init(void)
> -- 
> 1.7.12
> 

  reply	other threads:[~2012-10-30 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 15:56 [PATCH] omap2-clk: Add missing lcdc clock definition Pantelis Antoniou
2012-10-30 18:18 ` Tony Lindgren [this message]
2012-10-30 23:26   ` Paul Walmsley
2012-10-31  5:09     ` Hiremath, Vaibhav
2012-10-31  5:09       ` Hiremath, Vaibhav
2012-10-31  5:49       ` Paul Walmsley
2012-10-31  5:49         ` Paul Walmsley
2012-10-31  6:38         ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121030181837.GM11908@atomide.com \
    --to=tony@atomide.com \
    --cc=Russ.Dill@ti.com \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=panto@antoniou-consulting.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.