All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arvid Brodin <Arvid.Brodin@xdin.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	David Rientjes <rientjes@google.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?
Date: Tue, 30 Oct 2012 21:22:17 +0000	[thread overview]
Message-ID: <20121030212217.GD2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <50904066.4060404@xdin.com>

On Tue, Oct 30, 2012 at 09:02:33PM +0000, Arvid Brodin wrote:

> +config PROC_TEXT_MD5SUM
> +	bool "/proc/<pid>/text_md5sum support"
> +	depends on PROC_FS
> +	select CRYPTO
> +	select CRYPTO_MD5
> +	help
> +	  Read /proc/<pid>/text_md5sum to get the kernel to perform an MD5
> +	  checksum over the process' text segment and print the result. Can be
> +	  used to make sure a process' code has not been tampered with.

Sorry, but this is pointless.  Any attacker capable of modifying the code
will be just as capable of modifying pointers to functions in data segment.
IOW, you are not making sure of anything useful.

  reply	other threads:[~2012-10-30 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 21:02 fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE? Arvid Brodin
2012-10-30 21:22 ` Al Viro [this message]
2012-11-01 20:22   ` Arvid Brodin
2012-10-30 21:23 ` Cyrill Gorcunov
2012-10-30 22:45 ` Eric W. Biederman
2012-11-01 20:29   ` Arvid Brodin
2012-11-02 22:49     ` Arvid Brodin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121030212217.GD2616@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=Arvid.Brodin@xdin.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.