From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dirk Hohndel <dirk@hohndel.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Add support for the MacBook Pro 10,2 keyboard / touchpad
Date: Tue, 30 Oct 2012 22:48:54 -0700 [thread overview]
Message-ID: <20121031054854.GA31983@core.coreip.homeip.net> (raw)
In-Reply-To: <13ab3c9f72c.2202.2747.dirk@hohndel.org>
Hi Dirk,
On Tue, Oct 30, 2012 at 03:28:08PM -0700, Dirk Hohndel wrote:
> On October 30, 2012 3:22:11 PM "Henrik Rydberg" <rydberg@euromail.se> wrote:
> >Hi Dirk,
> >
> >
> >
> >The entry in hid_mouse_ignore_list seems to be missing.
>
> Correct. It works fine without that.
Pure luck I think as entries for bcm5974 get sorted before entries for
HID. To be safe and make sure it works if hid is built-in we need to add
the new devices to hid_mouse_ignore_list.
>
> I'm on my phone but I think there's a comment somewhere that for
> certain multi-touch devices the ignore wasn't needed.
That for devices driven by hid-multitouch, so not applicable to this
case.
>
> The keyboard definitely needs it, though.
>
> Let me phrase it this way: the patch, as submitted, happily works on my rMBP 13
By pure luck.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-10-31 5:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 19:51 [PATCH] Add support for the MacBook Pro 10,2 keyboard / touchpad Dirk Hohndel
2012-10-30 22:22 ` Henrik Rydberg
2012-10-30 22:28 ` Dirk Hohndel
2012-10-31 5:48 ` Dmitry Torokhov [this message]
2012-10-31 6:02 ` Dirk Hohndel
2012-10-31 6:34 ` Dmitry Torokhov
2012-10-31 7:41 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031054854.GA31983@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dirk@hohndel.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.