All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: mouse: alps: print small buffers via %*ph
Date: Tue, 30 Oct 2012 22:55:18 -0700	[thread overview]
Message-ID: <20121031055518.GD31983@core.coreip.homeip.net> (raw)
In-Reply-To: <1351258978-18656-1-git-send-email-andriy.shevchenko@linux.intel.com>

On Fri, Oct 26, 2012 at 04:42:58PM +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied, thank you Andy.
 
> ---
>  drivers/input/mouse/alps.c |   14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index cf5af1f..b4a3faf 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -766,10 +766,9 @@ static psmouse_ret_t alps_handle_interleaved_ps2(struct psmouse *psmouse)
>  		      psmouse->packet[4] |
>  		      psmouse->packet[5]) & 0x80) ||
>  		    (!alps_is_valid_first_byte(priv->i, psmouse->packet[6]))) {
> -			psmouse_dbg(psmouse,
> -				    "refusing packet %x %x %x %x (suspected interleaved ps/2)\n",
> -				    psmouse->packet[3], psmouse->packet[4],
> -				    psmouse->packet[5], psmouse->packet[6]);
> +			psmouse_dbg(psmouse, "refusing packet %4ph "
> +				    "(suspected interleaved ps/2)\n",
> +				    psmouse->packet + 3);
>  			return PSMOUSE_BAD_DATA;
>  		}
>  
> @@ -830,10 +829,9 @@ static void alps_flush_packet(unsigned long data)
>  		if ((psmouse->packet[3] |
>  		     psmouse->packet[4] |
>  		     psmouse->packet[5]) & 0x80) {
> -			psmouse_dbg(psmouse,
> -				    "refusing packet %x %x %x (suspected interleaved ps/2)\n",
> -				    psmouse->packet[3], psmouse->packet[4],
> -				    psmouse->packet[5]);
> +			psmouse_dbg(psmouse, "refusing packet %3ph "
> +				    "(suspected interleaved ps/2)\n",
> +				    psmouse->packet + 3);
>  		} else {
>  			alps_process_packet(psmouse);
>  		}
> -- 
> 1.7.10.4
> 

-- 
Dmitry

      reply	other threads:[~2012-10-31  5:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 13:42 [PATCH] Input: mouse: alps: print small buffers via %*ph Andy Shevchenko
2012-10-31  5:55 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121031055518.GD31983@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.