From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] tsc40: remove wrong announcement of pressure support
Date: Tue, 30 Oct 2012 23:41:08 -0700 [thread overview]
Message-ID: <20121031064108.GA7953@core.coreip.homeip.net> (raw)
In-Reply-To: <3551576.vuikKUmT5K@devpool02>
On Fri, Oct 26, 2012 at 09:35:57AM +0200, Rolf Eike Beer wrote:
> The tsc40 driver announces it supports the pressure event, but will never send
> one. The announcement will cause tslib to wait for such events and sending all
> touch events with a pressure of 0. Removing the announcement will make tslib
> fall back to emulating the pressure on touch events so everything works as
> expected.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> Cc: stable@vger.kernel.org
Applied, thank you Rolf.
> ---
> drivers/input/touchscreen/tsc40.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
> index 63209aa..eb96f16 100644
> --- a/drivers/input/touchscreen/tsc40.c
> +++ b/drivers/input/touchscreen/tsc40.c
> @@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
> __set_bit(BTN_TOUCH, input_dev->keybit);
> input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
> input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
> - input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
>
> serio_set_drvdata(serio, ptsc);
>
> --
> 1.7.11.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
prev parent reply other threads:[~2012-10-31 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 7:35 [PATCH] tsc40: remove wrong announcement of pressure support Rolf Eike Beer
2012-10-31 6:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031064108.GA7953@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.