Re: [uclinux-dist-devel] [PATCH RFC net-next 2/4] bfin_mac: replace sys time stamps with raw ones instead.

[Richard Cochran <richardcochran@gmail.com>]

On Wed, Oct 31, 2012 at 02:47:21PM +0800, Bob Liu wrote:
> > @@ -861,15 +854,9 @@ static void bfin_tx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
> >                         regval = bfin_read_EMAC_PTP_TXSNAPLO();
> >                         regval |= (u64)bfin_read_EMAC_PTP_TXSNAPHI() << 32;
> >                         memset(&shhwtstamps, 0, sizeof(shhwtstamps));
> > -                       ns = timecounter_cyc2time(&lp->clock,
> > -                                       regval);
> > -                       timecompare_update(&lp->compare, ns);
> > +                       ns = regval >> lp->shift;
> 
> Why not set ns = regval << lp->shift?
> I think it's conflicted with patch [3/4]

Yes, you are right. I will fix this in V2.

> > @@ -892,51 +879,25 @@ static void bfin_rx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
> >
> >         regval = bfin_read_EMAC_PTP_RXSNAPLO();
> >         regval |= (u64)bfin_read_EMAC_PTP_RXSNAPHI() << 32;
> > -       ns = timecounter_cyc2time(&lp->clock, regval);
> > -       timecompare_update(&lp->compare, ns);
> > +       ns = regval >> lp->shift;
> 
> So is here.

Thanks for the careful review,
Richard