From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH 2/3] dma: apbh: check for errors when resetting ip core
Date: Wed, 31 Oct 2012 10:29:56 +0100 [thread overview]
Message-ID: <201210311029.56456.jbe@pengutronix.de> (raw)
In-Reply-To: <20121031085414.GC2582@pengutronix.de>
Wolfram Sang wrote:
> On Wed, Oct 31, 2012 at 09:48:31AM +0100, Juergen Beisert wrote:
> > Wolfram Sang wrote:
> > > On Wed, Oct 31, 2012 at 09:29:56AM +0100, Juergen Beisert wrote:
> > > > Wolfram Sang wrote:
> > > > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > > > > ---
> > > > > drivers/dma/apbh_dma.c | 4 +++-
> > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/dma/apbh_dma.c b/drivers/dma/apbh_dma.c
> > > > > index 363878f..d30b8fb 100644
> > > > > --- a/drivers/dma/apbh_dma.c
> > > > > +++ b/drivers/dma/apbh_dma.c
> > > > > @@ -555,7 +555,9 @@ int mxs_dma_init(void)
> > > > > int ret, channel;
> > > > > u32 val, reg;
> > > > >
> > > > > - mxs_reset_block(apbh_regs, 0);
> > > > > + ret = mxs_reset_block(apbh_regs, 0);
> > > > > + if (ret)
> > > > > + return ret;
> > > >
> > > > In this case the user faces a "MXS: Timeout resetting block via
> > > > register ...". Do you think this message is helpful to give the user
> > > > a pointer *where* the failure happens?
> > >
> > > Yes, since it points to the IP core which was used here. Which again,
> > > makes clear which driver was trying to reset the IP core.
> >
> > You mean the reported register offset points to the corresponding IP
> > core?
>
> Yes, sure. Otherwise the error message would be useless :)
>
> > But also Barebox has more users than developers.
>
> There is nothing a user could do in this case except asking a developer
> what could have happened? And that's the best option here.
"MXS: Timeout resetting block via register <friesel>. Please ask the developer
for a solution"
:))
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-31 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:21 [PATCH 1/3] arm: mxs: use timeouts in block reset routines Wolfram Sang
2012-10-30 14:21 ` [PATCH 2/3] dma: apbh: check for errors when resetting ip core Wolfram Sang
2012-10-31 8:29 ` Juergen Beisert
2012-10-31 8:36 ` Wolfram Sang
2012-10-31 8:48 ` Juergen Beisert
2012-10-31 8:54 ` Wolfram Sang
2012-10-31 9:29 ` Juergen Beisert [this message]
2012-10-31 9:39 ` Wolfram Sang
2012-10-30 14:21 ` [PATCH 3/3] mtd: nand: mxs: " Wolfram Sang
2012-10-31 7:37 ` [PATCH 1/3] arm: mxs: use timeouts in block reset routines Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210311029.56456.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.