From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Shan Wei <shanwei88@gmail.com>
Cc: dipankar@in.ibm.com,
Kernel-Maillist <linux-kernel@vger.kernel.org>,
cl@linux-foundation.org
Subject: Re: [PATCH 7/9] rcu: use this_cpu_ptr per-cpu helper instead of per_cpu_ptr(p, raw_smp_processor_id())
Date: Wed, 31 Oct 2012 06:35:39 -0700 [thread overview]
Message-ID: <20121031133539.GY3027@linux.vnet.ibm.com> (raw)
In-Reply-To: <50912593.8050305@gmail.com>
On Wed, Oct 31, 2012 at 09:20:19PM +0800, Shan Wei wrote:
> Paul E. McKenney said, at 2012/10/31 19:51:
> >
> > The first uses smp_processor_id(), which will complain if
> > force_quiescent_state() is called with preemption disabled, which it
> > sometimes is.
> >
> > So what am I missing here?
>
> Hi Paul
>
> this patch is not right for CONFIG_DEBUG_PREEMPT case.
> __this_cpu_ptr is ok which do not check for preemption context.
Ah, got it. Please feel free to submit an updated patch.
Thanx, Paul
next prev parent reply other threads:[~2012-10-31 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:23 [PATCH 7/9] rcu: use this_cpu_ptr per-cpu helper instead of per_cpu_ptr(p, raw_smp_processor_id()) Shan Wei
2012-10-31 11:51 ` Paul E. McKenney
2012-10-31 13:20 ` Shan Wei
2012-10-31 13:35 ` Paul E. McKenney [this message]
2012-10-31 17:47 ` Christoph Lameter
2012-10-31 20:08 ` Paul E. McKenney
2012-11-01 9:09 ` Shan Wei
2012-11-01 14:32 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031133539.GY3027@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=cl@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shanwei88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.