From: Matt Kraai <kraai@ftbfs.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string
Date: Wed, 31 Oct 2012 08:48:07 -0700 [thread overview]
Message-ID: <20121031154807.GA19483@ftbfs.org> (raw)
In-Reply-To: <20121031140636.GA24291@sigill.intra.peff.net>
On Wed, Oct 31, 2012 at 10:06:36AM -0400, Jeff King wrote:
> On Tue, Oct 30, 2012 at 06:43:51PM +0000, Matt Kraai wrote:
>
> > Michael Haggerty <mhagger <at> alum.mit.edu> writes:
> > > + if (*params_copy)
> >
> > params_copy is set to the value returned by xstrdup, which cannot be NULL.
> > This check can be removed and if params_string can be NULL, it should be
> > checked before being passed to xstrdup.
>
> If you are referring to the last line, isn't it checking whether the
> string is empty, not NULL?
Oops, you're right. Sorry for misreading that.
--
Matt Kraai
https://ftbfs.org/kraai
prev parent reply other threads:[~2012-10-31 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 16:50 [PATCH] parse_dirstat_params(): use string_list to split comma-separated string Michael Haggerty
2012-10-30 18:43 ` Matt Kraai
2012-10-31 14:06 ` Jeff King
2012-10-31 15:48 ` Matt Kraai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031154807.GA19483@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.