From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 5/8] cgroup: remove CGRP_WAIT_ON_RMDIR, cgroup_exclude_rmdir() and cgroup_release_and_wakeup_rmdir() Date: Wed, 31 Oct 2012 10:16:44 -0700 Message-ID: <20121031171644.GG2945@htj.dyndns.org> References: <1351657365-25055-1-git-send-email-tj@kernel.org> <1351657365-25055-6-git-send-email-tj@kernel.org> <20121031162735.GF22809@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=M6A/xyXRvYsRVwcKonRob0lztJ8v3xMve0KXYoCnzsM=; b=AYyW0PfaOCvdgqkOxzQ9gJp3vwjhJUNptGM72w5vRFDQH1o/1vgLJdHEw4PhfHc2PT rGiHiD68wibWnFlYsxv/aN6dETnWEDuWpOjENqqpmQQwwaCwXNX47EVTihZkpUnRpuZz a+czwwm1XiuF1Ti+ln7XovNMfhEkKlQgnmsFyS7TcuDfWLeP/t6AoaZ4+ZtuBda6qbsj M/8beFfOskU/STszJaH/+PgEVDpFSycPyme1gSLSahB0wY6m9iRK1b8gUOM7ynr5d10y erWC0otvYZwps7EBaxdUHLRRBndmH4/q1L2I7tWtNUxw2V108hufKNdm+r4KIwMNOP4N ehRA== Content-Disposition: inline In-Reply-To: <20121031162735.GF22809-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Michal Hocko Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On Wed, Oct 31, 2012 at 05:27:35PM +0100, Michal Hocko wrote: > > --- > > include/linux/cgroup.h | 21 --------------------- > > kernel/cgroup.c | 51 -------------------------------------------------- > > mm/memcontrol.c | 24 +----------------------- > > 3 files changed, 1 insertion(+), 95 deletions(-) > > /me likes this Amen, Michal. The amount of code deleted isn't much but it was one ugly thing. The comment in memcg around the use of exclude_rmdir was very depressing. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758293Ab2JaRQw (ORCPT ); Wed, 31 Oct 2012 13:16:52 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:45904 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679Ab2JaRQt (ORCPT ); Wed, 31 Oct 2012 13:16:49 -0400 Date: Wed, 31 Oct 2012 10:16:44 -0700 From: Tejun Heo To: Michal Hocko Cc: lizefan@huawei.com, hannes@cmpxchg.org, bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] cgroup: remove CGRP_WAIT_ON_RMDIR, cgroup_exclude_rmdir() and cgroup_release_and_wakeup_rmdir() Message-ID: <20121031171644.GG2945@htj.dyndns.org> References: <1351657365-25055-1-git-send-email-tj@kernel.org> <1351657365-25055-6-git-send-email-tj@kernel.org> <20121031162735.GF22809@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121031162735.GF22809@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2012 at 05:27:35PM +0100, Michal Hocko wrote: > > --- > > include/linux/cgroup.h | 21 --------------------- > > kernel/cgroup.c | 51 -------------------------------------------------- > > mm/memcontrol.c | 24 +----------------------- > > 3 files changed, 1 insertion(+), 95 deletions(-) > > /me likes this Amen, Michal. The amount of code deleted isn't much but it was one ugly thing. The comment in memcg around the use of exclude_rmdir was very depressing. Thanks. -- tejun