From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: cjb@laptop.org, shawn.guo@linaro.org, linux-mmc@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] mmc: mxs-mmc: Remove platform data
Date: Wed, 31 Oct 2012 17:38:18 +0100 [thread overview]
Message-ID: <201210311738.18915.marex@denx.de> (raw)
In-Reply-To: <1351682578-12922-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> All MXS users have been converted to device tree and the board files have
> been removed.
>
> No need to keep platform data in the driver.
>
> Also move bus_width declaration in the beggining of mxs_mmc_probe() to
> avoid: 'warning: ISO C90 forbids mixed declarations and code'.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
[...]
You might want to do the same for MXS SPI driver.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-10-31 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:22 [PATCH v2] mmc: mxs-mmc: Remove platform data Fabio Estevam
2012-10-31 15:45 ` Shawn Guo
2012-10-31 15:49 ` Fabio Estevam
2012-11-17 20:32 ` Chris Ball
2012-10-31 16:38 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210311738.18915.marex@denx.de \
--to=marex@denx.de \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.