From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs Date: Wed, 31 Oct 2012 22:23:42 +0100 Message-ID: <20121031212342.GA5286@dhcp22.suse.cz> References: <1351712650-23709-1-git-send-email-tj@kernel.org> <1351712650-23709-2-git-send-email-tj@kernel.org> <20121031201227.GF1271@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=L/CqU7/a+VZRj0psfN9r+ujilJhwvTi7pW4PivY9WZQ=; b=Gcoyx1D8Yda0Aa0zMARwgBb4M1U1ZELt5DjjU+McyBxCU9C3kYm/f5Jno+VU4HLsMC ifCp1/kyAqvkocwmgz4tWWGJ/2QUmab57QMcTN4+L0ECIa0ngb6QVTpLjPm8X9QuS9II dHUrNHbE6GA+4XDzV7DyfTlcxkrSvB2lM3782Cgviy/xk2Khi3WyXH0H+cFGwp+2T3wj 7nN32lfABvPZs2MVtmiFiPja48jPVUKIyn7dLT/tqlBtcX+dY+Nr7LYmowdJ0SWXHSZi srXOwcPoWqd8c8TZdRLStbHZXz1On9MwGagh3886lLYjYOPT3nAenxIFVjgog9L9bP+Y rG3Q== Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On Wed 31-10-12 13:14:07, Tejun Heo wrote: > Hey, Michal. > > On Wed, Oct 31, 2012 at 1:12 PM, Michal Hocko wrote: > > And sorry for being to annoying about this WARN_ON_ONCE but I really > > don't see any reason for it. pre_destroy can still happen and now it is > > even reduced to a reasonable condition (somebody shown up). So I would > > put it out of way as it doesn't give us anything and as I've already > > mentioned one can trigger it really easily. > > It was there before and goes away in several commits. I have to > explain all that to remove it in this patch. Why do that when the > whole thing is just gonna disappear anyway? I would consider it nicer but if you feel it is not worth it then don't worry. It is not a big deal. The important part is that we do not ignore the return value now. Thanks -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946011Ab2JaVXr (ORCPT ); Wed, 31 Oct 2012 17:23:47 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:54413 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965470Ab2JaVXp (ORCPT ); Wed, 31 Oct 2012 17:23:45 -0400 Date: Wed, 31 Oct 2012 22:23:42 +0100 From: Michal Hocko To: Tejun Heo Cc: lizefan@huawei.com, hannes@cmpxchg.org, bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs Message-ID: <20121031212342.GA5286@dhcp22.suse.cz> References: <1351712650-23709-1-git-send-email-tj@kernel.org> <1351712650-23709-2-git-send-email-tj@kernel.org> <20121031201227.GF1271@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 31-10-12 13:14:07, Tejun Heo wrote: > Hey, Michal. > > On Wed, Oct 31, 2012 at 1:12 PM, Michal Hocko wrote: > > And sorry for being to annoying about this WARN_ON_ONCE but I really > > don't see any reason for it. pre_destroy can still happen and now it is > > even reduced to a reasonable condition (somebody shown up). So I would > > put it out of way as it doesn't give us anything and as I've already > > mentioned one can trigger it really easily. > > It was there before and goes away in several commits. I have to > explain all that to remove it in this patch. Why do that when the > whole thing is just gonna disappear anyway? I would consider it nicer but if you feel it is not worth it then don't worry. It is not a big deal. The important part is that we do not ignore the return value now. Thanks -- Michal Hocko SUSE Labs