Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Oct 30, 2012 at 08:08:30PM +0400, Alexander Shiyan wrote:
> This patch adds new architecture (CLPS711X) into barebox.
> The core-logic functionality of the device is built around an ARM720T
> processor running at clock speeds up to 90 MHz.
> 

[...]

> +++ b/arch/arm/mach-clps711x/reset.c
> @@ -0,0 +1,20 @@
> +/*
> + * Copyright (C) 2012 Alexander Shiyan <shc_work@mail.ru>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + */
> +
> +#include <common.h>
> +#include <asm/barebox-arm-head.h>
> +
> +void __noreturn reset_cpu(unsigned long addr)
> +{
> +	common_reset();

Oops. Naming the entry functions 'reset' really was a bad idea of mine.
common_reset() really is for the entry functions and should probably
rather be named common_entry(). It has nothing to do with preparing for
resetting the cpu.

> +
> +	asm("mov pc, #0");

Or is it because you do not have a real reset function and have to jump
through zero instead? Still common_reset() shouldn't be necessary. What
you may have to do here is to make sure the MMU is disabled and caches
are flushed.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox