From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: clkfwk: bugfix: sh_clk_div_enable() care sh_clk_div_set_rate() if div6
Date: Thu, 01 Nov 2012 00:22:33 +0000 [thread overview]
Message-ID: <20121101002233.GC24257@linux-sh.org> (raw)
In-Reply-To: <87pq45mxd9.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Oct 31, 2012 at 12:01:03AM -0700, Kuninori Morimoto wrote:
>
> Hi Paul
>
> > > 764f4e4e33d18cde4dcaf8a0d860b749c6d6d08b
> > > (sh: clkfwk: Use shared sh_clk_div_enable/disable())
> > > shared enable/disable funcions for div4/div6.
> > > But new sh_clk_div_enable() didn't care sh_clk_div_set_rate()
> > > which is required on div6 clock.
> > > This patch fixes it, and is tested by HDMI sound output on armadillo800eva
> > >
> > > Reported-by: Cao Minh Hiep <hiepcm@gmail.com>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Looks good, I'll queue it up, thanks.
>
> Thanks.
> But which branch can I find it ?
>
I have it on my laptop and haven't had a chance to push it yet. Now that
I think about it though, I'm not sure that CLK_MASK_DIV_ON_DISABLE should
be depended on. If you require this to only apply for div6 you are better
off checking the div mask directly (ie, testing SH_CLK_DIV6_MSK).
prev parent reply other threads:[~2012-11-01 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 8:49 [PATCH] sh: clkfwk: bugfix: sh_clk_div_enable() care sh_clk_div_set_rate() if div6 Kuninori Morimoto
2012-10-27 7:45 ` Paul Mundt
2012-10-31 7:01 ` Kuninori Morimoto
2012-11-01 0:22 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101002233.GC24257@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.