Re: [PATCH] ASoC: mxs-saif: Fix channel swap for 24-bit format

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1021 bytes --]

On Wed, Oct 31, 2012 at 04:50:50PM +0800, Dong Aisheng wrote:
> On 31 October 2012 07:07, Fabio Estevam <festevam@gmail.com> wrote:

> > +                        * write data to saif data register to trigger
> > +                        * the transfer.
> > +                        * For 24-bit format the 32-bit FIFO register stores
> > +                        * only one channel, so we need to write twice.
> >                          */
> >                         __raw_writel(0, saif->base + SAIF_DATA);
> > +                       __raw_writel(0, saif->base + SAIF_DATA);

> This probably could a workaround for the customer, but i'm not sure
> Mark could accept it
> since the code is a bit confusing. (Mark, what's your suggestion on this?)

I'm not really concerned about the code, the comment is fairly clear
except that it'd be good to mention that this is safe for data sizes
other than 24 bit.  It's certainly really much more confusing than the
existing code and if it works better that's obviously good!

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]