From: Alan Cox <alan@linux.intel.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
gregkh@linuxfoundation.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, seth.heasley@intel.com,
yongjun_wei@trendmicro.com.cn, linux-serial@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup()
Date: Thu, 1 Nov 2012 14:48:52 +0000 [thread overview]
Message-ID: <20121101144852.763ffa6f@bob.linux.org.uk> (raw)
In-Reply-To: <50928060.3010806@ti.com>
> > "clk or clock-frequency not
> > defined\n");
> > - return -ENODEV;
> > + return PTR_ERR(info->clk);
> I think this is wrong. it should return -ENODEV;
Returning the clock error at least ensures the real reason for the fail
is reported. I think its better to use the PTR_ERR but I'd not class
either as wrong.
Alan
next prev parent reply other threads:[~2012-11-01 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 5:27 [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup() Wei Yongjun
2012-11-01 14:00 ` Murali Karicheri
2012-11-01 14:48 ` Alan Cox [this message]
2012-11-15 12:08 ` Grant Likely
2012-11-16 1:22 ` Greg KH
2012-11-16 2:21 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101144852.763ffa6f@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=rob.herring@calxeda.com \
--cc=seth.heasley@intel.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.