From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: at91: add a sanity check on i2c message length Date: Thu, 1 Nov 2012 23:29:22 +0100 Message-ID: <20121101222922.GD22956@pengutronix.de> References: <1349879158-27268-1-git-send-email-ludovic.desroches@atmel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="g7w8+K/95kPelPD2" Return-path: Content-Disposition: inline In-Reply-To: <1349879158-27268-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org List-Id: linux-i2c@vger.kernel.org --g7w8+K/95kPelPD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 10, 2012 at 04:25:58PM +0200, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org wrote: > From: Ludovic Desroches >=20 > If the i2c message length is zero, i2c-at91 will directly return an error > instead of trying to send a zero-length message. >=20 > Signed-off-by: Ludovic Desroches What happens if you send a 0 byte message? Some hardware is able to do this and it will be used in SMBUS QUICK which the driver states to support according to at91_twi_func(). Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --g7w8+K/95kPelPD2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlCS98IACgkQD27XaX1/VRsRRACeLgODxdfLWOFKRlWG99mExylX 504AmwQ4Rvo4c0olB7t9IVu4YfG8+92Y =nd4E -----END PGP SIGNATURE----- --g7w8+K/95kPelPD2-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: w.sang@pengutronix.de (Wolfram Sang) Date: Thu, 1 Nov 2012 23:29:22 +0100 Subject: [PATCH] i2c: at91: add a sanity check on i2c message length In-Reply-To: <1349879158-27268-1-git-send-email-ludovic.desroches@atmel.com> References: <1349879158-27268-1-git-send-email-ludovic.desroches@atmel.com> Message-ID: <20121101222922.GD22956@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 10, 2012 at 04:25:58PM +0200, ludovic.desroches at atmel.com wrote: > From: Ludovic Desroches > > If the i2c message length is zero, i2c-at91 will directly return an error > instead of trying to send a zero-length message. > > Signed-off-by: Ludovic Desroches What happens if you send a 0 byte message? Some hardware is able to do this and it will be used in SMBUS QUICK which the driver states to support according to at91_twi_func(). Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: