From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
changlongx.xie@intel.com, fengguang.wu@intel.com,
netdev@vger.kernel.org
Subject: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack
Date: Fri, 2 Nov 2012 10:06:31 +0800 [thread overview]
Message-ID: <20121102020631.GI16883@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <509326ff.Rs30l/1GTlOl9dW+%yuanhan.liu@linux.intel.com>
Hi Richard,
_just_ FYI and let you aware of it, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: b77bc2069d1e437d5a1a71bb5cfcf4556ee40015
commit: 215b13dd288c2e1e4461c1530a801f5f83e8cd90 [122/152] ptp: add an ioctl to compare PHC time with system time
+ drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack
drivers/ptp/ptp_chardev.c:144 ptp_read() warn: 'event' puts 960 bytes on stack
vim +36 +/sysoff drivers/ptp/ptp_chardev.c
d94ba80e Richard Cochran 2011-04-22 20 #include <linux/module.h>
d94ba80e Richard Cochran 2011-04-22 21 #include <linux/posix-clock.h>
d94ba80e Richard Cochran 2011-04-22 22 #include <linux/poll.h>
d94ba80e Richard Cochran 2011-04-22 23 #include <linux/sched.h>
d94ba80e Richard Cochran 2011-04-22 24
d94ba80e Richard Cochran 2011-04-22 25 #include "ptp_private.h"
d94ba80e Richard Cochran 2011-04-22 26
d94ba80e Richard Cochran 2011-04-22 27 int ptp_open(struct posix_clock *pc, fmode_t fmode)
d94ba80e Richard Cochran 2011-04-22 28 {
d94ba80e Richard Cochran 2011-04-22 29 return 0;
d94ba80e Richard Cochran 2011-04-22 30 }
d94ba80e Richard Cochran 2011-04-22 31
d94ba80e Richard Cochran 2011-04-22 32 long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
d94ba80e Richard Cochran 2011-04-22 33 {
d94ba80e Richard Cochran 2011-04-22 34 struct ptp_clock_caps caps;
d94ba80e Richard Cochran 2011-04-22 35 struct ptp_clock_request req;
215b13dd Richard Cochran 2012-10-31 @36 struct ptp_sys_offset sysoff;
d94ba80e Richard Cochran 2011-04-22 37 struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
d94ba80e Richard Cochran 2011-04-22 38 struct ptp_clock_info *ops = ptp->info;
215b13dd Richard Cochran 2012-10-31 39 struct ptp_clock_time *pct;
215b13dd Richard Cochran 2012-10-31 40 struct timespec ts;
d94ba80e Richard Cochran 2011-04-22 41 int enable, err = 0;
215b13dd Richard Cochran 2012-10-31 42 unsigned int i;
d94ba80e Richard Cochran 2011-04-22 43
d94ba80e Richard Cochran 2011-04-22 44 switch (cmd) {
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
next parent reply other threads:[~2012-11-02 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <509326ff.Rs30l/1GTlOl9dW+%yuanhan.liu@linux.intel.com>
2012-11-02 2:06 ` Yuanhan Liu [this message]
2012-11-02 8:59 ` [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack Richard Cochran
2012-11-03 1:39 ` David Miller
2012-11-03 4:53 ` Richard Cochran
2012-11-03 5:39 ` David Miller
2012-11-26 11:44 ` [PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps Richard Cochran
2012-11-26 11:44 ` [PATCH net-next 2/2] ptp: reduce stack usage when measuring the system time offset Richard Cochran
2012-11-26 22:23 ` David Miller
2012-11-26 22:23 ` [PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102020631.GI16883@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=changlongx.xie@intel.com \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.