All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Anton Arapov <anton@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Rabin Vincent <rabin@rab.in>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume()
Date: Fri, 2 Nov 2012 10:32:18 +0530	[thread overview]
Message-ID: <20121102050218.GD11125@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121029124325.GA31397@redhat.com>

> Subject: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume()
> 
> Cleanup. No need to clear TIF_UPROBE, uprobe_notify_resume() does this.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>


Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> ---
>  arch/powerpc/kernel/signal.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c
> index a2dc757..3b99711 100644
> --- a/arch/powerpc/kernel/signal.c
> +++ b/arch/powerpc/kernel/signal.c
> @@ -158,10 +158,8 @@ static int do_signal(struct pt_regs *regs)
> 
>  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
>  {
> -	if (thread_info_flags & _TIF_UPROBE) {
> -		clear_thread_flag(TIF_UPROBE);
> +	if (thread_info_flags & _TIF_UPROBE)
>  		uprobe_notify_resume(regs);
> -	}
> 
>  	if (thread_info_flags & _TIF_SIGPENDING)
>  		do_signal(regs);
> -- 
> 1.5.5.1
> 
> 


  parent reply	other threads:[~2012-11-02  5:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 17:39 [PATCH 0/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Oleg Nesterov
2012-10-28 17:39 ` [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume() Oleg Nesterov
2012-10-29  5:27   ` Ananth N Mavinakayanahalli
2012-10-29  7:02     ` Srikar Dronamraju
2012-10-29 12:43     ` Oleg Nesterov
2012-10-29 13:28       ` Ananth N Mavinakayanahalli
2012-11-02  5:02       ` Srikar Dronamraju [this message]
2012-10-28 17:39 ` [PATCH 2/4] uprobes/powerpc: Do not use arch_uprobe_*_step() helpers Oleg Nesterov
2012-10-29  5:33   ` Ananth N Mavinakayanahalli
2012-11-02  5:03   ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 3/4] uprobes/x86: Cleanup the single-stepping code Oleg Nesterov
2012-11-02 12:51   ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 4/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Oleg Nesterov
2012-11-02 12:50   ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102050218.GD11125@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=ananth@in.ibm.com \
    --cc=anton@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rabin@rab.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.