From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Edivaldo de Araujo Pereira <edivaldoapereira@yahoo.com.br>,
qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Bug 1066055 <1066055@bugs.launchpad.net>
Subject: Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead
Date: Fri, 2 Nov 2012 16:48:12 +0200 [thread overview]
Message-ID: <20121102144812.GA29519@redhat.com> (raw)
In-Reply-To: <CAJSP0QWD_KC4W6NLQVWAnn6kDPA8ncPt7rK9gA6shq0KFnMNOg@mail.gmail.com>
On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote:
> On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced
> > a regression in virtio-net performance because it looks
> > into the ring aggressively while we really only care
> > about a single packet worth of buffers.
> > To fix, add parameters limiting lookahead, and
> > use in virtqueue_avail_bytes.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: Edivaldo de Araujo Pereira <edivaldoapereira@yahoo.com.br>
>
> Nice, much simpler than the ideas I had.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Anthony could you apply this out of band please so this stops
biting people?
Thanks,
MST
next prev parent reply other threads:[~2012-11-02 14:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 17:34 [Qemu-devel] [Bug 1066055] [NEW] Network performance regression with vde_switch Edivaldo de Araujo Pereira
2012-10-15 8:58 ` Stefan Hajnoczi
2012-10-15 21:46 ` [Qemu-devel] [Bug 1066055] " Edivaldo de Araujo Pereira
2012-10-16 7:48 ` Stefan Hajnoczi
2012-10-22 11:18 ` Amit Shah
2012-10-22 13:50 ` Edivaldo de Araujo Pereira
2012-10-23 12:55 ` Stefan Hajnoczi
2012-11-01 9:19 ` Amit Shah
2012-11-01 12:04 ` Michael S. Tsirkin
2012-11-01 15:12 ` Amit Shah
2012-11-01 15:50 ` Michael S. Tsirkin
2012-11-01 16:07 ` [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead Michael S. Tsirkin
2012-11-02 9:56 ` Amit Shah
2012-11-02 10:18 ` Stefan Hajnoczi
2012-11-02 14:48 ` Michael S. Tsirkin [this message]
2012-11-02 19:44 ` Stefan Hajnoczi
2012-11-27 16:25 ` Michael S. Tsirkin
2012-11-27 16:54 ` Edivaldo de Araujo Pereira
2012-11-27 19:47 ` Anthony Liguori
2012-11-28 21:53 ` Michael S. Tsirkin
2012-11-29 13:04 ` Amit Shah
2012-11-29 14:10 ` Michael S. Tsirkin
2012-11-29 19:02 ` Anthony Liguori
2012-11-29 22:39 ` Michael S. Tsirkin
2012-11-01 11:42 ` [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch Michael S. Tsirkin
2012-10-16 12:23 ` Edivaldo de Araujo Pereira
2012-10-17 13:51 ` Stefan Hajnoczi
2018-01-10 21:28 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102144812.GA29519@redhat.com \
--to=mst@redhat.com \
--cc=1066055@bugs.launchpad.net \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=edivaldoapereira@yahoo.com.br \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.