From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device
Date: Sat, 3 Nov 2012 02:35:45 +0100 [thread overview]
Message-ID: <201211030235.45765.marex@denx.de> (raw)
In-Reply-To: <1351806388-27322-1-git-send-email-joe.hershberger@ni.com>
Dear Joe Hershberger,
> Each serial device is added as a console device. There was also the
> "serial" device that points to the most-recently-assigned-to-some-
> console-handle device. This can be confusing. Instead, only show the
> actual serial devices.
>
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
> common/console.c | 37 +++++++++++++++++++------------------
> common/stdio.c | 12 +-----------
> 2 files changed, 20 insertions(+), 29 deletions(-)
>
[...]
You also remove the nulldev, shouldn't it go via separate patch? ... but
otherwise it's good.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-03 1:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 21:46 [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device Joe Hershberger
2012-11-01 21:46 ` [U-Boot] [PATCH 2/2] serial: Make nulldev a serial device Joe Hershberger
2012-11-03 1:37 ` Marek Vasut
2012-11-05 0:24 ` Joe Hershberger
2012-11-05 23:10 ` Marek Vasut
2012-11-06 0:01 ` Joe Hershberger
2012-11-06 0:47 ` Marek Vasut
2012-11-06 1:00 ` Joe Hershberger
2012-11-06 1:11 ` Marek Vasut
2012-11-03 1:35 ` Marek Vasut [this message]
2012-11-05 0:20 ` [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device Joe Hershberger
2012-11-05 23:11 ` Marek Vasut
2012-11-05 23:45 ` Joe Hershberger
2012-11-05 23:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211030235.45765.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.