All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 9/9] hwmon: (it87) Report thermal sensor type as Intel PECI if appropriate
Date: Sat, 03 Nov 2012 16:03:25 +0000	[thread overview]
Message-ID: <20121103160325.GA21426@roeck-us.net> (raw)
In-Reply-To: <1351448401-13985-10-git-send-email-linux@roeck-us.net>

On Fri, Nov 02, 2012 at 06:31:34PM +0100, Jean Delvare wrote:
> On Fri, 2 Nov 2012 10:19:25 -0700, Guenter Roeck wrote:
> > On Fri, Nov 02, 2012 at 04:24:04PM +0100, Jean Delvare wrote:
> > > temp3_offset value of 116000 makes them match.
> >
> > Good, so at least we know that we have the correct register. The only remaining
> > question is if we should make tempX_offset unsigned if a sensor is configured
> > for AMDTSI. Kind of odd, though, since it is signed for everything else and
> > might thus change sign when/if the sensor type is changed. Not sure what the
> > best approach might be.
> 
> Treating it as unsigned when the type is set to AMD-SI is probably the
> way to go for now, although I would love to get more samples from users

Agreed.

> of AMD CPUs to make sure. I suppose we'll get more feedback after the
> patch series you send earlier this week hits mainline.
> 
and agreed.

I'll come up with one more patch to add support for AMD-SI to it8728f.
Hopefully sometime this weekend.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2012-11-03 16:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 18:20 [lm-sensors] [PATCH 9/9] hwmon: (it87) Report thermal sensor type as Intel PECI if appropriate Guenter Roeck
2012-10-29 16:55 ` Jean Delvare
2012-10-29 17:28 ` Guenter Roeck
2012-11-01 12:56 ` Jean Delvare
2012-11-01 13:40 ` Guenter Roeck
2012-11-01 16:37 ` Jean Delvare
2012-11-01 17:17 ` Guenter Roeck
2012-11-01 18:12 ` Jean Delvare
2012-11-01 20:54 ` Guenter Roeck
2012-11-01 21:18 ` Phil Pokorny
2012-11-02  3:09 ` Guenter Roeck
2012-11-02 15:24 ` Jean Delvare
2012-11-02 17:19 ` Guenter Roeck
2012-11-02 17:31 ` Jean Delvare
2012-11-03 16:03 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121103160325.GA21426@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.