From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] md5: Fix gcc-4.7 build problem in md5
Date: Sun, 04 Nov 2012 01:39:22 +0100 [thread overview]
Message-ID: <20121104003923.08BAE200056@gemini.denx.de> (raw)
In-Reply-To: <20121104003242.92729200056@gemini.denx.de>
Dear Simon,
In message <20121104003242.92729200056@gemini.denx.de> I wrote:
>
> > /* Append length in bits and transform */
> > - ctx->in32[14] = ctx->bits[0];
> > - ctx->in32[15] = ctx->bits[1];
> > + memcpy(ctx->in + 14 * sizeof(__u32), ctx->bits, 2 * sizeof(__u32));
>
> This makes the code actually unreadable. Please add at least a
> comment what this is doing.
Actually I think this shoul dbe split into two memcpy commands, using
the addresses of the respective array elements directly, without such
manual pointer arithmetics.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number of Unix installations has grown to 10, with more
expected." - The Unix Programmer's Manual, 2nd Edition, June, 1972
next prev parent reply other threads:[~2012-11-04 0:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 21:45 [U-Boot] [PATCH 1/3] lzma: update to lzma sdk 9.20 Simon Glass
2012-11-03 21:45 ` [U-Boot] [PATCH 2/3] md5: Fix gcc-4.7 build problem in md5 Simon Glass
2012-11-04 0:32 ` Wolfgang Denk
2012-11-04 0:39 ` Wolfgang Denk [this message]
2012-11-05 20:03 ` Pavel Machek
2012-11-05 20:50 ` Wolfgang Denk
2012-11-05 21:15 ` Han Shen(沈涵)
2012-11-05 22:51 ` Pavel Machek
2012-11-06 0:56 ` Marek Vasut
2012-11-06 11:07 ` Pavel Machek
2012-11-06 22:30 ` Marek Vasut
2012-11-07 22:18 ` Simon Glass
2012-11-03 21:45 ` [U-Boot] [PATCH 3/3] Add stricmp() and strnicmp() Simon Glass
2012-11-04 0:31 ` Wolfgang Denk
2012-11-04 4:38 ` Simon Glass
2012-11-04 22:47 ` Albert ARIBAUD
2012-11-07 22:00 ` Simon Glass
2012-11-22 2:51 ` Simon Glass
2012-12-07 15:49 ` [U-Boot] [U-Boot,1/3] lzma: update to lzma sdk 9.20 Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104003923.08BAE200056@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.