All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined
Date: Sun, 4 Nov 2012 11:31:13 +0100	[thread overview]
Message-ID: <20121104103113.GB27124@gmail.com> (raw)
In-Reply-To: <509623B0.2020605@metafoo.de>

Thanks for reviewing Lars. Here's the result:

commit c4f60d00d04abfb730a54a97204873dafc6473ae
Author: Lee Jones <lee.jones@linaro.org>
Date:   Sat Nov 3 22:54:23 2012 +0100

    ASoC: Only compile adav80x codec when a bus is defined
    
    If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support
    for the adav80x codec as it relies on a bus to operate. This patch
    fixes the build warnings below when SPI and I2C are not specified in
    the configuration.
    
    sound/soc/codecs/adav80x.c:842:22: warning: ‘adav80x_bus_probe’ defined but not used [-Wunused-function]
    sound/soc/codecs/adav80x.c:863:22: warning: ‘adav80x_bus_remove’ defined but not used [-Wunused-function]
    
    Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: alsa-devel@alsa-project.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index b92759a..3ae3a4b 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_AD1980 if SND_SOC_AC97_BUS
 	select SND_SOC_AD73311
 	select SND_SOC_ADAU1373 if I2C
-	select SND_SOC_ADAV80X
+	select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
 	select SND_SOC_ADS117X
 	select SND_SOC_AK4104 if SPI_MASTER
 	select SND_SOC_AK4535 if I2C

  reply	other threads:[~2012-11-04 10:31 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-03 22:02 [PATCH 0/9] Fixups for issues when running 'make randconfig' Lee Jones
2012-11-03 22:02 ` [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure Lee Jones
2012-11-03 22:02   ` Lee Jones
2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
2012-11-03 22:02   ` Lee Jones
2012-11-04 10:15   ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:15     ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:57     ` Lee Jones
2012-11-04 10:57       ` Lee Jones
2012-11-05  8:13   ` Josh Wu
2012-11-05  8:13     ` Josh Wu
2012-11-05  8:19     ` Lee Jones
2012-11-05  8:19       ` Lee Jones
2012-11-03 22:02 ` [PATCH 3/9] x86: Suppress build warnings in quirks Lee Jones
2012-11-03 22:02 ` [PATCH 4/9] sched: Don't define unthrottle_offline_cfs_rqs when !CONFIG_SMP Lee Jones
2012-11-03 22:02 ` [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Lee Jones
2012-11-03 22:02   ` Lee Jones
2012-11-04  8:13   ` [alsa-devel] " Lars-Peter Clausen
2012-11-04 10:31     ` Lee Jones [this message]
2012-11-03 22:02 ` [PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning Lee Jones
2012-11-03 22:02 ` Lee Jones
2012-11-05  2:38   ` Rusty Russell
2012-11-05  2:38     ` Rusty Russell
2012-11-05  8:21     ` Lee Jones
2012-11-05  8:21       ` Lee Jones
2012-11-05 13:00       ` Pawel Moll
2012-11-05 13:00         ` Pawel Moll
2012-11-05 13:02         ` [PATCH] virtio-mmio: Fix irq parsing in command line parameter Pawel Moll
2012-11-05 13:02           ` Pawel Moll
2012-11-05 13:44           ` Lee Jones
2012-11-05 13:44             ` Lee Jones
2012-11-05 14:12             ` Pawel Moll
2012-11-05 14:12               ` Pawel Moll
2012-11-05 14:35               ` Lee Jones
2012-11-05 14:35                 ` Lee Jones
2012-11-07 22:22             ` Rusty Russell
2012-11-08  9:48               ` Lee Jones
2012-11-08 12:23                 ` Rusty Russell
2012-11-08 12:23                   ` Rusty Russell
2012-11-07 14:18           ` [PATCH v2] virtio-mmio: Fix irq parsing in the command line Pawel Moll
2012-11-07 22:47             ` Rusty Russell
2012-11-08 19:05               ` [PATCH v3] virtio-mmio: Fix irq parsing in command line parameter Pawel Moll
2012-11-09  4:11                 ` Rusty Russell
2012-11-03 22:02 ` [PATCH 7/9] quota: Use the pre-processor to compile out quotactl_cmd_write when !CONFIG_BLOCK Lee Jones
2012-11-06 23:06   ` Jan Kara
2012-11-03 22:02 ` [PATCH 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:40   ` Paul Bolle
2012-11-03 22:48     ` Lee Jones
2012-11-04 10:14       ` Paul Bolle
2012-11-04 10:53         ` Lee Jones
2012-11-04 17:30           ` David Miller
2012-11-05  8:44             ` Lee Jones
2012-11-05  9:11               ` Paul Bolle
2012-11-05  9:44                 ` Lee Jones
2012-11-05 16:46               ` David Miller
2012-11-05 10:31             ` [PATCH 8/9] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES Lee Jones
2012-11-06 23:57               ` David Miller
2012-11-07  9:56                 ` Lee Jones
2012-11-04 10:28     ` [PATCH v2 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:02 ` [Bridge] [PATCH 9/9] Avoid 'statement with no effect' compiler warnings Lee Jones
2012-11-03 22:02   ` Lee Jones
2012-11-04  6:00   ` [Bridge] " David Miller
2012-11-04  6:00     ` David Miller
2012-11-04  7:55     ` [Bridge] " Lee Jones
2012-11-04  7:55       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121104103113.GB27124@gmail.com \
    --to=lee.jones@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.