From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 6/9] virtio_mmio: =?utf-8?Q?Cas?= =?utf-8?Q?t_&resources=5B1=5D=2Estart_to_=E2=80=98unsigned_int_*?= =?utf-8?B?4oCZ?= to rid compiler warning Date: Mon, 5 Nov 2012 09:21:16 +0100 Message-ID: <20121105082116.GB2699@gmail.com> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-7-git-send-email-lee.jones@linaro.org> <87k3u0ydry.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87k3u0ydry.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gTW9uLCAwNSBOb3YgMjAxMiwgUnVzdHkgUnVzc2VsbCB3cm90ZToKCj4gTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4gd3JpdGVzOgo+ID4gZHJpdmVycy92aXJ0aW8vdmlydGlvX21t aW8uYzogSW4gZnVuY3Rpb24g4oCYdm1fY21kbGluZV9zZXTigJk6Cj4gPiBkcml2ZXJzL3ZpcnRp by92aXJ0aW9fbW1pby5jOjUzNTo0OiB3YXJuaW5nOiBmb3JtYXQg4oCYJXXigJkgZXhwZWN0cyBh cmd1bWVudCBvZiB0eXBlIOKAmHVuc2lnbmVkIGludCAq4oCZLCBidXQgYXJndW1lbnQgNCBoYXMg dHlwZSDigJhyZXNvdXJjZV9zaXplX3QgKuKAmSBbLVdmb3JtYXRdCj4gPgo+ID4gQ2M6IFJ1c3R5 IFJ1c3NlbGwgPHJ1c3R5QHJ1c3Rjb3JwLmNvbS5hdT4KPiA+IENjOiB2aXJ0dWFsaXphdGlvbkBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvdmlydGlvL3ZpcnRpb19t bWlvLmMgfCAgICAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19tbWlv LmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fbW1pby5jCj4gPiBpbmRleCA2YjFiN2UxLi4wNzdl OWNhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX21taW8uYwo+ID4gKysr IGIvZHJpdmVycy92aXJ0aW8vdmlydGlvX21taW8uYwo+ID4gQEAgLTUzMSw3ICs1MzEsNyBAQCBz dGF0aWMgaW50IHZtX2NtZGxpbmVfc2V0KGNvbnN0IGNoYXIgKmRldmljZSwKPiA+ICAJcmVzb3Vy Y2VzWzBdLmVuZCA9IG1lbXBhcnNlKGRldmljZSwgJnN0cikgLSAxOwo+ID4gIAo+ID4gIAlwcm9j ZXNzZWQgPSBzc2NhbmYoc3RyLCAiQCVsbGk6JXUlbjolZCVuIiwKPiA+IC0JCQkmYmFzZSwgJnJl c291cmNlc1sxXS5zdGFydCwgJmNvbnN1bWVkLAo+ID4gKwkJCSZiYXNlLCAodW5zaWduZWQgaW50 ICopJnJlc291cmNlc1sxXS5zdGFydCwgJmNvbnN1bWVkLAo+ID4gIAkJCSZ2bV9jbWRsaW5lX2lk LCAmY29uc3VtZWQpOwo+IAo+IFRoaXMgc3VwcHJlc3NlcyBhIHZhbGlkIHdhcm5pbmcsIGxlYXZp bmcgb3VyIGNvZGUgbm8gbGVzcyB3cm9uZyB0aGFuCj4gYmVmb3JlLiAgQnV0IG5vdyBpdCdzIHNp bGVudGx5IHdyb25nIQo+IAo+IERvIHlvdSB3YW50IHRvIHRyeSBhZ2Fpbj8KCkZvciBzdXJlIEkn bGwgdHJ5IGFnYWluLgoKSG93IGRvZXMgYHMvJXUvJXAvYCBzdWl0PwoKLS0gCkxlZSBKb25lcwpM aW5hcm8gU1QtRXJpY3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBz b3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdp dHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146Ab2KEIVW (ORCPT ); Mon, 5 Nov 2012 03:21:22 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:59443 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979Ab2KEIVV (ORCPT ); Mon, 5 Nov 2012 03:21:21 -0500 Date: Mon, 5 Nov 2012 09:21:16 +0100 From: Lee Jones To: Rusty Russell Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 6/9] virtio_mmio: =?utf-8?Q?Cas?= =?utf-8?Q?t_&resources=5B1=5D=2Estart_to_=E2=80=98unsigned_int_*?= =?utf-8?B?4oCZ?= to rid compiler warning Message-ID: <20121105082116.GB2699@gmail.com> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-7-git-send-email-lee.jones@linaro.org> <87k3u0ydry.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k3u0ydry.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Nov 2012, Rusty Russell wrote: > Lee Jones writes: > > drivers/virtio/virtio_mmio.c: In function ‘vm_cmdline_set’: > > drivers/virtio/virtio_mmio.c:535:4: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 4 has type ‘resource_size_t *’ [-Wformat] > > > > Cc: Rusty Russell > > Cc: virtualization@lists.linux-foundation.org > > Signed-off-by: Lee Jones > > --- > > drivers/virtio/virtio_mmio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > > index 6b1b7e1..077e9ca 100644 > > --- a/drivers/virtio/virtio_mmio.c > > +++ b/drivers/virtio/virtio_mmio.c > > @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device, > > resources[0].end = memparse(device, &str) - 1; > > > > processed = sscanf(str, "@%lli:%u%n:%d%n", > > - &base, &resources[1].start, &consumed, > > + &base, (unsigned int *)&resources[1].start, &consumed, > > &vm_cmdline_id, &consumed); > > This suppresses a valid warning, leaving our code no less wrong than > before. But now it's silently wrong! > > Do you want to try again? For sure I'll try again. How does `s/%u/%p/` suit? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog