[PATCH] ASoC: codecs/wm8978: pll incorrectly configured when codec is master

[PATCH] ASoC: codecs/wm8978: pll incorrectly configured when codec is master

[Eric Millbrandt]

When MCLK is supplied externally and BCLK and LRC are configured as outputs
(codec is master), the PLL values are only calculated correctly on the first
transmission.  On subsequent transmissions, at differenct sample rates, the
wrong PLL values are used.  Test for f_opclk instead of f_pllout to determine
if the PLL values are needed.

Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
---
 sound/soc/codecs/wm8978.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c
index a706262..e329187 100644
--- a/sound/soc/codecs/wm8978.c
+++ b/sound/soc/codecs/wm8978.c
@@ -784,7 +784,7 @@ static int wm8978_hw_params(struct snd_pcm_substream *substream,
 		wm8978->mclk_idx = -1;
 		f_sel = wm8978->f_mclk;
 	} else {
-		if (!wm8978->f_pllout) {
+		if (!wm8978->f_opclk) {
 			/* We only enter here, if OPCLK is not used */
 			int ret = wm8978_configure_pll(codec);
 			if (ret < 0)
-- 
1.7.2.5

Re: [PATCH] ASoC: codecs/wm8978: pll incorrectly configured when codec is master

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 430 bytes --]

On Fri, Nov 02, 2012 at 05:05:44PM -0400, Eric Millbrandt wrote:
> When MCLK is supplied externally and BCLK and LRC are configured as outputs
> (codec is master), the PLL values are only calculated correctly on the first
> transmission.  On subsequent transmissions, at differenct sample rates, the
> wrong PLL values are used.  Test for f_opclk instead of f_pllout to determine
> if the PLL values are needed.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]