From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org, linux-sound@vger.kernel.org,
alsa-devel@alsa-project.org, plagnioj@jcrosoft.com
Subject: Re: [RFC patch v3 3/4] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 6 Nov 2012 09:48:14 +0100 [thread overview]
Message-ID: <20121106084814.GC5044@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352181474-19597-3-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, Nov 06, 2012 at 01:57:53PM +0800, Bo Shen wrote:
> static struct platform_device at91sam9260_ssc_device = {
> - .name = "at91rm9200_ssc",
> + .name = "at91rm9200_ssc_dai",
> .id = 0,
> .dev = {
No, this isn't converting things to device tree which presumably is the
goal here and obviously just doing the rename doesn't accomplish an
enormous amount. What I said was that you should instantiate the ASoC
adaption when the machine driver needs to use them. You shouldn't even
need a separate device for this.
Please do look at other platforms with similar hardware and do something
similar to them.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org, linux-sound@vger.kernel.org,
alsa-devel@alsa-project.org, plagnioj@jcrosoft.com
Subject: Re: [RFC patch v3 3/4] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 06 Nov 2012 08:48:14 +0000 [thread overview]
Message-ID: <20121106084814.GC5044@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352181474-19597-3-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, Nov 06, 2012 at 01:57:53PM +0800, Bo Shen wrote:
> static struct platform_device at91sam9260_ssc_device = {
> - .name = "at91rm9200_ssc",
> + .name = "at91rm9200_ssc_dai",
> .id = 0,
> .dev = {
No, this isn't converting things to device tree which presumably is the
goal here and obviously just doing the rename doesn't accomplish an
enormous amount. What I said was that you should instantiate the ASoC
adaption when the machine driver needs to use them. You shouldn't even
need a separate device for this.
Please do look at other platforms with similar hardware and do something
similar to them.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC patch v3 3/4] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 6 Nov 2012 09:48:14 +0100 [thread overview]
Message-ID: <20121106084814.GC5044@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352181474-19597-3-git-send-email-voice.shen@atmel.com>
On Tue, Nov 06, 2012 at 01:57:53PM +0800, Bo Shen wrote:
> static struct platform_device at91sam9260_ssc_device = {
> - .name = "at91rm9200_ssc",
> + .name = "at91rm9200_ssc_dai",
> .id = 0,
> .dev = {
No, this isn't converting things to device tree which presumably is the
goal here and obviously just doing the rename doesn't accomplish an
enormous amount. What I said was that you should instantiate the ASoC
adaption when the machine driver needs to use them. You shouldn't even
need a separate device for this.
Please do look at other platforms with similar hardware and do something
similar to them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121106/e051f0f7/attachment.sig>
next prev parent reply other threads:[~2012-11-06 8:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 5:57 [RFC patch v3 1/4] ARM: at91: atmel-ssc: add platform device id table Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 5:57 ` [RFC patch v3 2/4] ARM: at91: atmel-ssc: add device tree support Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 8:58 ` Mark Brown
2012-11-06 8:58 ` Mark Brown
2012-11-06 8:58 ` Mark Brown
2012-11-06 5:57 ` [RFC patch v3 3/4] ASoC: atmel-ssc-dai: register dai and pcm directly Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 8:48 ` Mark Brown [this message]
2012-11-06 8:48 ` Mark Brown
2012-11-06 8:48 ` Mark Brown
2012-11-06 9:32 ` Bo Shen
2012-11-06 9:32 ` Bo Shen
2012-11-06 9:32 ` Bo Shen
2012-11-06 11:39 ` Mark Brown
2012-11-06 11:39 ` Mark Brown
2012-11-06 11:39 ` Mark Brown
2012-11-07 7:38 ` Bo Shen
2012-11-07 7:38 ` Bo Shen
2012-11-07 7:38 ` Bo Shen
2012-11-06 5:57 ` [RFC patch v3 4/4] ASoC: sam9g20-wm8731: convert dt support Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 5:57 ` Bo Shen
2012-11-06 8:58 ` [RFC patch v3 1/4] ARM: at91: atmel-ssc: add platform device id table Mark Brown
2012-11-06 8:58 ` Mark Brown
2012-11-06 8:58 ` Mark Brown
[not found] ` <1352181474-19597-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-06 14:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-06 14:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-06 14:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-06 15:29 ` Nicolas Ferre
2012-11-06 15:29 ` Nicolas Ferre
2012-11-06 15:29 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106084814.GC5044@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.