From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dong Aisheng <dong.aisheng@linaro.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, shawn.guo@linaro.org,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2] ASoC: mxs-pcm: Fix fifo size
Date: Tue, 6 Nov 2012 10:07:06 +0100 [thread overview]
Message-ID: <20121106090706.GJ5044@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAP1dx+zSmfEeih4DP3=E-r5HZUYmEAf07WzTmgYypxP8DJ73RA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 754 bytes --]
On Sat, Nov 03, 2012 at 04:04:02AM +0800, Dong Aisheng wrote:
> On 2 November 2012 23:06, Mark Brown
> > On Wed, Oct 31, 2012 at 03:06:11PM -0200, Fabio Estevam wrote:
> >> According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
> >> - .fifo_size = 32,
> >> + .fifo_size = 4,
> > fifo_size should be specified in bytes so the original code looks
> > correct?
> Then, probably it should be 16.
Yup.
> BTW, it seems this param is not used anymore:
> http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html
> That may be the reason why i see some other platforms pcm code just
> set fifo_size to 0.
Hrm, right - that'll be why nobody noticed. Guess it doesn't matter any
more.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-11-06 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 17:06 [PATCH v2] ASoC: mxs-pcm: Fix fifo size Fabio Estevam
2012-11-02 15:06 ` Mark Brown
2012-11-02 20:04 ` Dong Aisheng
2012-11-06 9:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106090706.GJ5044@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dong.aisheng@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.