From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Clear unused fields of mode for framebuffer creation Date: Tue, 6 Nov 2012 13:27:56 +0200 Message-ID: <20121106112756.GX3791@intel.com> References: <1352154308-12441-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 38260A030C for ; Tue, 6 Nov 2012 03:28:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <1352154308-12441-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Nov 05, 2012 at 10:25:07PM +0000, Chris Wilson wrote: > With the stricter checks introduced in > commit ac911edae5960d7dccd9883f5fa5d25b591520de > Author: Ville Syrj=E4l=E4 > Date: Wed Oct 31 17:50:19 2012 +0200 > = > drm/i915: Check the framebuffer offset > = > (and friends), it became especially prudent to make sure that the > additional fields inside the mode were cleared before attempting to > create a framebuffer. In particular, the fb created for load detection > failed to do so and hence failed. > = > Signed-off-by: Chris Wilson > Cc: Ville Syrj=E4l=E4 I fixed one of these earlier, but apparently I missed this one. Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 9b2fbf9..5345f0e 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -6607,7 +6607,7 @@ intel_framebuffer_create_for_mode(struct drm_device= *dev, > int depth, int bpp) > { > struct drm_i915_gem_object *obj; > - struct drm_mode_fb_cmd2 mode_cmd; > + struct drm_mode_fb_cmd2 mode_cmd =3D { 0 }; > = > obj =3D i915_gem_alloc_object(dev, > intel_framebuffer_size_for_mode(mode, bpp)); > -- = > 1.7.10.4 -- = Ville Syrj=E4l=E4 Intel OTC