From: Andrew Morton <akpm@linux-foundation.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>, Minchan Kim <minchan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Jens Axboe <axboe@kernel.dk>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pm@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 3/6] block/genhd.c: apply pm_runtime_set_memalloc_noio on block devices
Date: Tue, 6 Nov 2012 15:24:27 -0800 [thread overview]
Message-ID: <20121106152427.dfde4c52.akpm@linux-foundation.org> (raw)
In-Reply-To: <1351931714-11689-4-git-send-email-ming.lei@canonical.com>
On Sat, 3 Nov 2012 16:35:11 +0800
Ming Lei <ming.lei@canonical.com> wrote:
> This patch applyes the introduced pm_runtime_set_memalloc_noio on
> block device so that PM core will teach mm to not allocate memory with
> GFP_IOFS when calling the runtime_resume and runtime_suspend callback
> for block devices and its ancestors.
>
> ...
>
> @@ -532,6 +533,13 @@ static void register_disk(struct gendisk *disk)
> return;
> }
> }
> +
> + /* avoid probable deadlock caused by allocating memory with
Again, please fix the comment style. Take a look at the rest of this file!
> + * GFP_KERNEL in runtime_resume callback of its all ancestor
> + * deivces
typo
> + */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>, Minchan Kim <minchan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Jens Axboe <axboe@kernel.dk>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pm@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 3/6] block/genhd.c: apply pm_runtime_set_memalloc_noio on block devices
Date: Tue, 6 Nov 2012 15:24:27 -0800 [thread overview]
Message-ID: <20121106152427.dfde4c52.akpm@linux-foundation.org> (raw)
In-Reply-To: <1351931714-11689-4-git-send-email-ming.lei@canonical.com>
On Sat, 3 Nov 2012 16:35:11 +0800
Ming Lei <ming.lei@canonical.com> wrote:
> This patch applyes the introduced pm_runtime_set_memalloc_noio on
> block device so that PM core will teach mm to not allocate memory with
> GFP_IOFS when calling the runtime_resume and runtime_suspend callback
> for block devices and its ancestors.
>
> ...
>
> @@ -532,6 +533,13 @@ static void register_disk(struct gendisk *disk)
> return;
> }
> }
> +
> + /* avoid probable deadlock caused by allocating memory with
Again, please fix the comment style. Take a look at the rest of this file!
> + * GFP_KERNEL in runtime_resume callback of its all ancestor
> + * deivces
typo
> + */
next prev parent reply other threads:[~2012-11-06 23:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 8:35 [PATCH v4 0/6] solve deadlock caused by memory allocation with I/O Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-03 8:35 ` [PATCH v4 1/6] mm: teach mm by current context info to not do I/O during memory allocation Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-06 23:23 ` Andrew Morton
2012-11-06 23:23 ` Andrew Morton
2012-11-07 3:11 ` Ming Lei
2012-11-07 3:11 ` Ming Lei
2012-11-07 3:48 ` Andrew Morton
2012-11-07 3:48 ` Andrew Morton
2012-11-07 4:35 ` Ming Lei
2012-11-07 4:35 ` Ming Lei
2012-11-03 8:35 ` [PATCH v4 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio() Ming Lei
2012-11-03 8:35 ` Ming Lei
[not found] ` <1351931714-11689-3-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2012-11-06 23:24 ` Andrew Morton
2012-11-06 23:24 ` Andrew Morton
2012-11-06 23:24 ` Andrew Morton
2012-11-07 3:32 ` Ming Lei
2012-11-07 3:32 ` Ming Lei
2012-11-03 8:35 ` [PATCH v4 3/6] block/genhd.c: apply pm_runtime_set_memalloc_noio on block devices Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-06 23:24 ` Andrew Morton [this message]
2012-11-06 23:24 ` Andrew Morton
2012-11-03 8:35 ` [PATCH v4 4/6] net/core: apply pm_runtime_set_memalloc_noio on network devices Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-03 8:35 ` [PATCH v4 5/6] PM / Runtime: force memory allocation with no I/O during Runtime PM callbcack Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-03 8:35 ` [PATCH v4 6/6] USB: forbid memory allocation with I/O during bus reset Ming Lei
2012-11-03 8:35 ` Ming Lei
2012-11-06 23:23 ` [PATCH v4 0/6] solve deadlock caused by memory allocation with I/O Andrew Morton
2012-11-06 23:23 ` Andrew Morton
2012-11-06 23:23 ` Andrew Morton
2012-11-07 3:37 ` Ming Lei
2012-11-07 3:37 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106152427.dfde4c52.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.