From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Add discard support for capable devices
Date: Tue, 6 Nov 2012 11:15:09 -0500 [thread overview]
Message-ID: <20121106161509.GU4244@linux.intel.com> (raw)
In-Reply-To: <20121106161008.GA1736@linux.intel.com>
On Tue, Nov 06, 2012@11:10:08AM -0500, Matthew Wilcox wrote:
> Although ... now I'm looking at the failure path in
> nvme_submit_bio_queue(), isn't it the case that we'll leak cmdids if
> nvme_map_bio() fails? And in this case? So I think we also need:
>
> + free_cmdid:
> + free_cmdid(nvmeq, cmdid, NULL);
> free_iod:
>
> And then change the 'goto free_iod' to 'goto free_cmdid'.
Never mind; just got to the patch where you fixed this :-)
next prev parent reply other threads:[~2012-11-06 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 18:59 [PATCH] NVMe: Add discard support for capable devices Keith Busch
2012-11-06 16:10 ` Matthew Wilcox
2012-11-06 16:15 ` Matthew Wilcox [this message]
2012-11-06 16:19 ` Busch, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106161509.GU4244@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.