From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Tue, 6 Nov 2012 15:06:39 -0800 Subject: [U-Boot] [PATCH] USB: add arrow key support to usb_kbd In-Reply-To: <201211062356.37374.marex@denx.de> References: <1352237163-26765-1-git-send-email-amartin@nvidia.com> <201211062349.30125.marex@denx.de> <201211062356.37374.marex@denx.de> Message-ID: <20121106230638.GC21647@badger> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Nov 06, 2012 at 02:56:37PM -0800, Marek Vasut wrote: > Dear Simon Glass, > > > Hi Marek, > > > > On Tue, Nov 6, 2012 at 2:49 PM, Marek Vasut wrote: > > > Dear Allen Martin, > > > > > >> Check for scancodes for arrow keys and map them to ^F/^B, ^N/^P. > > >> Control characters are used instead of ANSI sequence because the > > >> queueing code in usb_kbd doesn't handle the data increase when one > > >> keypress generates 3 keycodes. The real fix is to convert this driver > > >> to use the input subsystem and queue > > > > > > If it's the real fix, then why not go for the real fix right away? :-( > > > > Because it's a fair chunk of work > > Let's either do it properly or not at all ... if I let you do these semi- > complete fixes, we'll end up with a stinking pile of crap like windows ... > I'm definately on board with changing it over to use input, it seems like the right thing to do. I just wasn't signing up to do the work right now. I'm happy to help review patches though if someone else wants to jump in. -Allen -- nvpublic