All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] usb: ehci: Take advantage of the new multi-controller feature for MXC
Date: Tue, 6 Nov 2012 23:35:59 +0100	[thread overview]
Message-ID: <201211062335.59526.marex@denx.de> (raw)
In-Reply-To: <1352187823.1483.6.camel@tellur>

Dear Lucas Stach,

[...]

> > > > > What do you think?
> > > > 
> > > > What about passing port private / platform data instead of ID ?
> > > 
> > > The ID is already passed to ehci_hcd_init(), so we have to live with it
> > > if we don't want to change the newly introduced multi-controller
> > > infrastructure.
> > 
> > Let's change it .... remove the ID and pass some generic pdata.
> 
> I don't like the idea of passing around data at this level. It's
> breaking the abstraction, as we have to pass low-level usb information
> around in the higher USB stack levels.

Good, what do you suggest we do when we apply driver model onto this stuff?

> The USB driver code should be able to do the virt-to-phys controller
> mapping on it's own. In the Tegra world

Tegra is completely unimportant part of the usb ecosystem.

> we use the information we get
> from device tree to do so, but I don't see a reason why your USB host
> driver code wouldn't be able to just require an array with configuration
> data from the board file.

I don't see how you transfer DT information into controller # ...

> There is really no need to pass this information through all the USB
> stack interfaces.

Please explain.

> Regards,
> Lucas

  parent reply	other threads:[~2012-11-06 22:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1242814866.587541.1352146777830.JavaMail.root@advansee.com>
2012-11-05 20:50 ` [U-Boot] usb: ehci: Take advantage of the new multi-controller feature for MXC Benoît Thébaudeau
2012-11-05 22:54   ` Marek Vasut
2012-11-05 23:52     ` Benoît Thébaudeau
2012-11-05 23:56       ` Marek Vasut
2012-11-06  7:43         ` Lucas Stach
2012-11-06 19:59           ` Benoît Thébaudeau
2012-11-06 22:38             ` Marek Vasut
2012-11-06 22:35           ` Marek Vasut [this message]
2012-11-06 23:03             ` Lucas Stach
2012-11-07 13:25               ` Marek Vasut
2012-11-07 13:57                 ` Lucas Stach
2012-11-07 14:13                   ` Marek Vasut
2012-11-18 16:19                     ` Benoît Thébaudeau
2012-11-18 16:21                       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211062335.59526.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.