From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Rafael <rjw@sisk.pl>,
Kevin Hilman <khilman@ti.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
linux-pm <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3/6] ARM: OMAP: voltage: move voltdm_reset to platform_data header
Date: Tue, 6 Nov 2012 17:18:08 -0800 [thread overview]
Message-ID: <20121107011808.GZ6801@atomide.com> (raw)
In-Reply-To: <20121106214819.GA16246@kahuna>
* Nishanth Menon <nm@ti.com> [121106 13:50]:
> On 10:49-20121106, Tony Lindgren wrote:
> >
> > Looks like there are other things there too that's not platform data:
> >
> > struct voltagedomain *voltdm_lookup(const char *name);
> > int voltdm_scale(struct voltagedomain *voltdm, unsigned long target_volt);
> > unsigned long voltdm_get_voltage(struct voltagedomain *voltdm);
> > struct omap_volt_data *omap_voltage_get_voltdata(struct voltagedomain *voltdm,
> > unsigned long volt);
> >
> > Can you please add a patch fixing that ASAP?
>
> Agreed include/linux/platform_data/voltage-omap.h has more functions as well.
> Considering it did:
> rename arch/arm/plat-omap/include/plat/voltage.h =>
> include/linux/platform_data/voltage-omap.h
>
> Where do we move these functions to?
>
> drivers/power/avs/smartreflex.c needs:
> omap_voltage_get_voltdata
> and
> drivers/power/avs/smartreflex-class3.c
> will need voltdm_reset and voltdm_get_voltage
How about something local drivers/power/avs/smartreflex.h?
Regards,
Tony
next prev parent reply other threads:[~2012-11-07 1:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 15:02 [PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs Nishanth Menon
2012-11-05 15:02 ` Nishanth Menon
2012-11-05 15:02 ` [PATCH 1/6] PM / AVS / OMAP: move Kconfig definition of smartreflex to avs directory Nishanth Menon
2012-11-05 15:02 ` [PATCH 2/6] ARM: OMAP: voltage: remove duplicate header definitions Nishanth Menon
2012-11-05 15:02 ` [PATCH 3/6] ARM: OMAP: voltage: move voltdm_reset to platform_data header Nishanth Menon
2012-11-06 18:49 ` Tony Lindgren
2012-11-06 21:48 ` Nishanth Menon
2012-11-07 1:18 ` Tony Lindgren [this message]
2012-11-07 1:28 ` Nishanth Menon
2012-11-07 1:46 ` Tony Lindgren
2012-11-08 4:52 ` Nishanth Menon
2012-11-05 15:02 ` [PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP Nishanth Menon
2012-11-05 15:02 ` [PATCH 5/6] ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning Nishanth Menon
2012-11-05 15:02 ` [PATCH 6/6] PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107011808.GZ6801@atomide.com \
--to=tony@atomide.com \
--cc=cbouatmailru@gmail.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.