From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH V2 0/2] Provide more precise dump info for memcg-oom Date: Wed, 7 Nov 2012 11:31:07 -0800 Message-ID: <20121107113107.d91eba43.akpm@linux-foundation.org> References: <1352277602-21687-1-git-send-email-handai.szj@taobao.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1352277602-21687-1-git-send-email-handai.szj@taobao.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Sha Zhengju Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz, kamezawa.hiroyu@jp.fujitsu.com, rientjes@google.com, linux-kernel@vger.kernel.org, Sha Zhengju On Wed, 7 Nov 2012 16:40:02 +0800 Sha Zhengju wrote: > When memcg oom is happening the current memcg related dump information > is limited for debugging. The patches provide more detailed memcg page statistics > and also take hierarchy into consideration. Within the changelogs, please include a sample of the proposed output so we can properly review the proposal. Also it would be useful to provide some justification for the decisions in this patch: which data is displayed and, particularly, which is not? Why is the displayed information useful to developers, etc. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701Ab2KGTbK (ORCPT ); Wed, 7 Nov 2012 14:31:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53037 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab2KGTbI (ORCPT ); Wed, 7 Nov 2012 14:31:08 -0500 Date: Wed, 7 Nov 2012 11:31:07 -0800 From: Andrew Morton To: Sha Zhengju Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz, kamezawa.hiroyu@jp.fujitsu.com, rientjes@google.com, linux-kernel@vger.kernel.org, Sha Zhengju Subject: Re: [PATCH V2 0/2] Provide more precise dump info for memcg-oom Message-Id: <20121107113107.d91eba43.akpm@linux-foundation.org> In-Reply-To: <1352277602-21687-1-git-send-email-handai.szj@taobao.com> References: <1352277602-21687-1-git-send-email-handai.szj@taobao.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Nov 2012 16:40:02 +0800 Sha Zhengju wrote: > When memcg oom is happening the current memcg related dump information > is limited for debugging. The patches provide more detailed memcg page statistics > and also take hierarchy into consideration. Within the changelogs, please include a sample of the proposed output so we can properly review the proposal. Also it would be useful to provide some justification for the decisions in this patch: which data is displayed and, particularly, which is not? Why is the displayed information useful to developers, etc.