All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Alexandra Chin <Alexandra.Chin@tw.synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Input <linux-input@vger.kernel.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
	Mahesh Srinivasan <msrinivasan@synaptics.com>,
	Alex Chang <alex.chang@tw.synaptics.com>,
	Scott Lin <scott.lin@tw.synaptics.com>,
	Christopher Heiny <Cheiny@synaptics.com>
Subject: Re: [PATCH v4] staging: ste_rmi4: Convert to Type-B support
Date: Wed, 7 Nov 2012 20:57:08 +0100	[thread overview]
Message-ID: <20121107195708.GA3754@polaris.bitmath.org> (raw)
In-Reply-To: <20121107134934.b37e923588f4a24af146a93b@tw.synaptics.com>

Hi Alexandra,

> Convert to MT-B because Synaptics touch devices are capable of tracking
> identifiable fingers.
> 
> Signed-off-by: Alexandra Chin <alexandra.chin@tw.synaptics.com>
> ---
> Changes from v4:
>         - Incorporated Henrik's review comments
>           *split function synpatics_rmi4_touchscreen_report
>           *split function synaptics_rmi4_i2c_query_device

Thanks for the changes. The patch looks cleaner, but also much larger,
containing many changes irrelevant to the commit message (and to what
has hitherto been reviewed). Please resend a minimum patch, there is
plenty of room for additional patches after this one. :-)

Thanks,
Henrik

  reply	other threads:[~2012-11-07 19:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 17:36 [PATCH v3] staging: ste_rmi4: Convert to Type-B support Alexandra Chin
2012-11-04 21:53 ` Henrik Rydberg
2012-11-05  6:01   ` Alexandra Chin
2012-11-12 11:59   ` Alexandra Chin
2012-11-07  5:49 ` [PATCH v4] " Alexandra Chin
2012-11-07 19:57   ` Henrik Rydberg [this message]
2012-11-08  4:01     ` Alexandra Chin
2012-11-08  7:05 ` [PATCH v5] " Alexandra Chin
2012-11-09 19:26   ` Henrik Rydberg
2012-11-12 16:40     ` Alexandra Chin
2012-11-12 17:20       ` Henrik Rydberg
2012-11-13  2:04         ` Alexandra Chin
2012-11-13 12:12 ` [PATCH v6] " Alexandra Chin
2012-11-13 17:53   ` Henrik Rydberg
2012-11-14 17:33     ` Alexandra Chin
2012-11-14 17:40     ` [RFC] staging: ste_rmi4: merge into the main kernel tree Alexandra Chin
2012-11-14 18:04       ` Dmitry Torokhov
2012-11-15  2:56         ` Alexandra Chin
2012-11-15  6:43           ` Dmitry Torokhov
2012-11-15 17:41             ` Linus Walleij
2012-11-15 18:55               ` Dmitry Torokhov
2012-11-15 19:05                 ` Linus Walleij
2012-11-16  9:02             ` Alexandra Chin
2012-11-16 19:24               ` Dmitry Torokhov
2012-11-16  8:31 ` [PATCH v6] staging: ste_rmi4: Convert to Type-B support Alexandra Chin
2012-11-16 19:54   ` Henrik Rydberg
2012-11-16 19:50     ` Greg Kroah-Hartman
2012-12-06 11:30       ` Alexandra Chin
2012-12-06 16:34         ` Greg Kroah-Hartman
2012-12-07  4:01           ` Alexandra Chin
2012-12-07  5:11             ` Greg Kroah-Hartman
2012-12-07  6:45               ` Alexandra Chin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121107195708.GA3754@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=Alexandra.Chin@tw.synaptics.com \
    --cc=Cheiny@synaptics.com \
    --cc=alex.chang@tw.synaptics.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msrinivasan@synaptics.com \
    --cc=naveen.gaddipati@stericsson.com \
    --cc=scott.lin@tw.synaptics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.