All of lore.kernel.org
 help / color / mirror / Atom feed
From: dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [patch RFC 4/6] Wait for link ready before use the interface
Date: Thu, 08 Nov 2012 11:40:22 +0800	[thread overview]
Message-ID: <20121108034317.594728251@redhat.com> (raw)
In-Reply-To: 20121108034018.789330224@redhat.com

[-- Attachment #1: network-wait-for-link-ready-before-use.patch --]
[-- Type: text/plain, Size: 1258 bytes --]

Some network driver will take long time to initialize. We have an example
in a HP machine which take about one minute for this. The callback such as
"ip link set <dev> up" will fail, afterwards setup for network will also
fail.

Fix this by add a new function wait_for_if_link, wait the link ready before
use it.

Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 modules.d/40network/net-lib.sh |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

--- dracut.orig/modules.d/40network/net-lib.sh
+++ dracut/modules.d/40network/net-lib.sh
@@ -316,6 +316,19 @@ parse_ifname_opts() {
 
 }
 
+# some network driver need long time to initialize, wait before it's ready.
+wait_for_if_link() {
+    local cnt=0
+    local li
+    while [ $cnt -lt 600 ]; do
+        li=$(ip -o link show dev $1 2>/dev/null)
+        [ -n "$li" ] && return 0
+        sleep 0.1
+        cnt=$(($cnt+1))
+    done
+    return 1
+}
+
 wait_for_if_up() {
     local cnt=0
     local li
@@ -340,6 +353,8 @@ wait_for_route_ok() {
 }
 
 linkup() {
-    ip link set $1 up 2>/dev/null && wait_for_if_up $1 2>/dev/null
+    wait_for_if_link $1 2>/dev/null\
+     && ip link set $1 up 2>/dev/null\
+     && wait_for_if_up $1 2>/dev/null
 }
 

  parent reply	other threads:[~2012-11-08  3:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08  3:40 [patch RFC 0/6] network fixes for link waiting dyoung-H+wXaHxf7aLQT0dZR+AlfA
2012-11-08  3:40 ` [patch RFC 1/6] Move wait for if functions to net lib dyoung-H+wXaHxf7aLQT0dZR+AlfA
     [not found]   ` <20121108034317.171739916-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-08  9:50     ` Dave Young
2012-11-08  3:40 ` [patch RFC 2/6] Add function linkup dyoung-H+wXaHxf7aLQT0dZR+AlfA
2012-11-08  3:40 ` [patch RFC 3/6] Change to use linkup function in network scripts dyoung-H+wXaHxf7aLQT0dZR+AlfA
2012-11-08  3:40 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA [this message]
2012-11-08  3:40 ` [patch RFC 5/6] Get ifaces for udev rule use dyoung-H+wXaHxf7aLQT0dZR+AlfA
     [not found]   ` <20121108034317.735680044-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-29  8:07     ` Dave Young
2012-11-08  3:40 ` [patch RFC 6/6] Wait for interface up at the early stage dyoung-H+wXaHxf7aLQT0dZR+AlfA
     [not found]   ` <20121108034317.844374819-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-29  8:09     ` Dave Young
     [not found] ` <20121108034018.789330224-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-14  8:49   ` [patch RFC 0/6] network fixes for link waiting Dave Young
     [not found]     ` <50A35B2E.9050206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-14 10:56       ` Harald Hoyer
     [not found]         ` <50A378F0.4030907-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-15  1:52           ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121108034317.594728251@redhat.com \
    --to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.